From: Lancelot SIX <lsix@lancelotsix.com>
To: Bruno Larsen <blarsen@redhat.com>
Cc: gdb-patches@sourceware.org, Eli Zaretskii <eliz@gnu.org>
Subject: Re: [PATCH v3] gdb: add 'maintenance print record-instruction' command
Date: Tue, 3 Jan 2023 16:10:45 +0000 [thread overview]
Message-ID: <20230103161045.ia4ldkemvsorbals@ubuntu.lan> (raw)
In-Reply-To: <1a74eebc-2ecd-7334-b702-52185c6820bf@redhat.com>
Hi,
> > I do not think the rest of the test makes much sense if
> > [supports_process_record] returns false, does it? I guess that
> > everything below this point should be be in the if block.
> >
> > Another approach might to have the initial test (at the top of the file)
> > check for both supports_reverse and supports_process_record and ignore
> > the test if either feature is not supported. WDYT?
> Good call, but since I do think it makes sense to test that GDB doesn't go
> wild even if recording is not supported, I think I'll make the test exit
> early here instead.
That seems good to me.
> >
> > For what it is worth, the rest of the patch looks OK to me.
> Awesome, may I add your R-b tag, or do you want to see my change to the test
> first?
Sure, with the test modified as discussed above this seems OK to me. Please add
Reviewed-By: Lancelot SIX <lancelot.six@amd.com>
Best,
Lancelot.
next prev parent reply other threads:[~2023-01-03 16:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-22 15:43 Bruno Larsen
2023-01-02 15:37 ` Alexandra Petlanova Hajkova
2023-01-03 9:00 ` Bruno Larsen
2023-01-02 16:26 ` Lancelot SIX
2023-01-02 16:56 ` Bruno Larsen
2023-01-03 16:10 ` Lancelot SIX [this message]
2023-01-03 17:04 ` Tom Tromey
2023-01-04 10:30 ` Bruno Larsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230103161045.ia4ldkemvsorbals@ubuntu.lan \
--to=lsix@lancelotsix.com \
--cc=blarsen@redhat.com \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).