Re: [PATCH v3] gdb: add 'maintenance print record-instruction' command

[Bruno Larsen <blarsen@redhat.com>]

On 22/12/2022 16:43, Bruno Larsen wrote:
> While chasing some reverse debugging bugs, I found myself wondering what
> was recorded by GDB to undo and redo a certain instruction. This commit
> implements a simple way of printing that information.
>
> If there isn't enough history to print the desired instruction (such as
> when the user hasn't started recording yet or when they request 2
> instructions back but only 1 was recorded), GDB warns the user like so:
>
> (gdb) maint print record-instruction
> Not enough recorded history
>
> If there is enough, GDB prints the instruction like so:
>
> (gdb) maint print record-instruction
> 4 bytes of memory at address 0x00007fffffffd5dc changed from: 01 00 00 00
> Register eflags changed: [ IF ]
> Register rip changed: (void (*)()) 0x401115 <main+15>
>
> Approved-by: Eli Zaretskii<eliz@gnu.org>

Thanks everyone who reviewed. I implemented the suggestions and pushed 
the patch

-- 
Cheers,
Bruno