From: Alexandra Petlanova Hajkova <ahajkova@redhat.com>
To: Bruno Larsen <blarsen@redhat.com>
Cc: gdb-patches@sourceware.org, Eli Zaretskii <eliz@gnu.org>
Subject: Re: [PATCH v3] gdb: add 'maintenance print record-instruction' command
Date: Mon, 2 Jan 2023 16:37:11 +0100 [thread overview]
Message-ID: <CAJVr-EOt3UoTE_Q4e_2o2gfdVG9-2QiWAp7L4XZ66=VY7x7BdA@mail.gmail.com> (raw)
In-Reply-To: <20221222154338.2223678-1-blarsen@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 464 bytes --]
> +# This file is part of the GDB testsuite. it tests the functionality of
> +# the maintenance print record-instruction command, but does not check the
> +# syntax, only if the command finds or fails to find recorded history.
> +
> +if ![supports_reverse] {
> + return
> +}
> +
>
I think this patch is good to go in general.
But it might be nice to add a small summary about how the test works as a
comment at the beginning of the test?
Regards,
Alexandra
next prev parent reply other threads:[~2023-01-02 15:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-22 15:43 Bruno Larsen
2023-01-02 15:37 ` Alexandra Petlanova Hajkova [this message]
2023-01-03 9:00 ` Bruno Larsen
2023-01-02 16:26 ` Lancelot SIX
2023-01-02 16:56 ` Bruno Larsen
2023-01-03 16:10 ` Lancelot SIX
2023-01-03 17:04 ` Tom Tromey
2023-01-04 10:30 ` Bruno Larsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJVr-EOt3UoTE_Q4e_2o2gfdVG9-2QiWAp7L4XZ66=VY7x7BdA@mail.gmail.com' \
--to=ahajkova@redhat.com \
--cc=blarsen@redhat.com \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).