From: Tom Tromey <tom@tromey.com>
To: gdb-patches@sourceware.org
Subject: [PATCH 0/8] Use 'require' even more
Date: Sun, 22 Jan 2023 14:55:50 -0700 [thread overview]
Message-ID: <20230122215558.1931803-1-tom@tromey.com> (raw)
This changes many more tests to use 'require'.
I think the benefits here are two-fold.
First, this is more terse and more importantly, consistent across
tests. This means it's harder to accidentally early-exit without a
reason.
Second, a test exiting silently seems bad to me, because it requires
investigation into the reason why (which I, for one, never do). If
every test has to give a reason that it did not run, we could detect a
change in that reason using a comparison script.
There's a bit of discussion of this in:
https://sourceware.org/bugzilla/show_bug.cgi?id=29778
... read that for some background and also perhaps a different view.
Tom
next reply other threads:[~2023-01-22 21:56 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-22 21:55 Tom Tromey [this message]
2023-01-22 21:55 ` [PATCH 1/8] Convert skip_altivec_tests to allow form Tom Tromey
2023-01-23 19:45 ` Pedro Alves
2023-01-24 19:53 ` Tom Tromey
2023-01-22 21:55 ` [PATCH 2/8] Rename skip_float_test " Tom Tromey
2023-01-22 21:55 ` [PATCH 3/8] Rename skip_power_isa_3_1_tests " Tom Tromey
2023-01-22 21:55 ` [PATCH 4/8] Rename skip_vsx_tests " Tom Tromey
2023-01-22 21:55 ` [PATCH 5/8] Use require with istarget Tom Tromey
2023-01-22 21:55 ` [PATCH 6/8] Introduce and use is_any_target Tom Tromey
2023-01-23 19:57 ` Pedro Alves
2023-01-24 19:41 ` Tom Tromey
2023-01-22 21:55 ` [PATCH 7/8] Add unsupported calls where needed Tom Tromey
2023-01-22 21:55 ` [PATCH 8/8] Use require with is_remote Tom Tromey
2023-01-23 20:08 ` Pedro Alves
2023-01-24 19:48 ` Tom Tromey
2023-01-24 19:50 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230122215558.1931803-1-tom@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).