Re: [PATCH 8/8] Use require with is_remote

[Tom Tromey <tom@tromey.com>]

>> -if [is_remote host] {
>> -    unsupported "compiling on a remote host does not support a filename with directory."
>> -    return 0
>> -}
>> +require {!is_remote host}

Pedro> IWBN to preserve "compiling on a remote host does not support a filename with directory."
Pedro> as a comment.

I fixed this in all the spots where it occurred.

>> --- a/gdb/testsuite/gdb.base/gdbhistsize-history.exp
>> +++ b/gdb/testsuite/gdb.base/gdbhistsize-history.exp
>> @@ -21,10 +21,7 @@
>> # We cannot expect remote hosts to see environment variables set on the
>> # local machine.
>> 
>> -if { [is_remote host] } {
>> -    unsupported "can't set environment variables on remote host"
>> -    return -1
>> -}
>> +require {!is_remote host}

Pedro> Similarly here.

In all the "environment variables" cases, there was already a comment.
In this hunk you can see it at the top of the context.

I've changed this code to move the comment one line closer so it's more
obvious.

>> -    # gdbserver prints the warning message but expect is parsing only the GDB
>> -    # output, not the gdbserver output.
>> -    return 0
>> -}
>> +require {!is_remote target}

Pedro> Ditto, comment should be preserved, IMO.  

I fixed this.

Pedro> There are a few more, I've not pointed at every one.

I went through the patch and I think I made sure all the interesting
comments are preserved.

Tom