From: Tom Tromey <tom@tromey.com>
To: Pedro Alves <pedro@palves.net>
Cc: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH 1/8] Convert skip_altivec_tests to allow form
Date: Tue, 24 Jan 2023 12:53:03 -0700 [thread overview]
Message-ID: <874jsfk8v4.fsf@tromey.com> (raw)
In-Reply-To: <43d91f20-d1d7-9797-195a-8ed136a660f3@palves.net> (Pedro Alves's message of "Mon, 23 Jan 2023 19:45:49 +0000")
>>>>> "Pedro" == Pedro Alves <pedro@palves.net> writes:
Pedro> On 2023-01-22 9:55 p.m., Tom Tromey wrote:
>> -if {![istarget "powerpc*"] || [skip_altivec_tests]} {
>> +require allow_altivec_tests
>> +if {![istarget "powerpc*"]} {
>> verbose "Skipping altivec abi tests."
>> return
>> }
Pedro> Something preexisting, and that can be done after your patch, but
Pedro> I note that it's odd that we have to check [istarget "powerpc*"]
Pedro> explicitly. I don't think there are non-Power altivec systems?
Pedro> I think the istarget check would be better moved inside
Pedro> allow_altivec_tests. All existing callers have that same
Pedro> istarget check, even.
I've tacked on a patch to do this.
Tom
next prev parent reply other threads:[~2023-01-24 19:53 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-22 21:55 [PATCH 0/8] Use 'require' even more Tom Tromey
2023-01-22 21:55 ` [PATCH 1/8] Convert skip_altivec_tests to allow form Tom Tromey
2023-01-23 19:45 ` Pedro Alves
2023-01-24 19:53 ` Tom Tromey [this message]
2023-01-22 21:55 ` [PATCH 2/8] Rename skip_float_test " Tom Tromey
2023-01-22 21:55 ` [PATCH 3/8] Rename skip_power_isa_3_1_tests " Tom Tromey
2023-01-22 21:55 ` [PATCH 4/8] Rename skip_vsx_tests " Tom Tromey
2023-01-22 21:55 ` [PATCH 5/8] Use require with istarget Tom Tromey
2023-01-22 21:55 ` [PATCH 6/8] Introduce and use is_any_target Tom Tromey
2023-01-23 19:57 ` Pedro Alves
2023-01-24 19:41 ` Tom Tromey
2023-01-22 21:55 ` [PATCH 7/8] Add unsupported calls where needed Tom Tromey
2023-01-22 21:55 ` [PATCH 8/8] Use require with is_remote Tom Tromey
2023-01-23 20:08 ` Pedro Alves
2023-01-24 19:48 ` Tom Tromey
2023-01-24 19:50 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874jsfk8v4.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=pedro@palves.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).