public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Simon Marchi <simon.marchi@polymtl.ca>
To: gdb-patches@sourceware.org
Cc: Simon Marchi <simon.marchi@polymtl.ca>
Subject: [PATCH 0/4] Move index reading code out of dwarf2/read.c
Date: Mon, 13 Feb 2023 09:55:55 -0500	[thread overview]
Message-ID: <20230213145559.46676-1-simon.marchi@polymtl.ca> (raw)

This is a small series to move some code out of dwarf2/read.c.  It makes
a small dent in that file's length.  Before the series, it is 23953
lines long, and after 21941 (~8% reduction).  But most importantly (at
least for me), it makes it clear that some functions are only used for
reading either .gdb_index or .debug_names, which was not obvious when
they were all in read.c.

Simon Marchi (4):
  gdb/dwarf2: rename some things, index -> gdb_index
  gdb/dwarf2: move some things to read.h
  gdb/dwarf2: split .gdb_index reading code to own file
  gdb/dwarf2: split .debug_names reading code to own file

 gdb/Makefile.in               |    4 +
 gdb/dwarf2/read-debug-names.c | 1052 ++++++++++++++
 gdb/dwarf2/read-debug-names.h |   30 +
 gdb/dwarf2/read-gdb-index.c   |  835 ++++++++++++
 gdb/dwarf2/read-gdb-index.h   |   47 +
 gdb/dwarf2/read.c             | 2426 +++------------------------------
 gdb/dwarf2/read.h             |  223 +++
 7 files changed, 2398 insertions(+), 2219 deletions(-)
 create mode 100644 gdb/dwarf2/read-debug-names.c
 create mode 100644 gdb/dwarf2/read-debug-names.h
 create mode 100644 gdb/dwarf2/read-gdb-index.c
 create mode 100644 gdb/dwarf2/read-gdb-index.h


base-commit: 14d0e6818a022b72c265f15f63c8ccc2fc8c302a
-- 
2.39.1


             reply	other threads:[~2023-02-13 14:56 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-13 14:55 Simon Marchi [this message]
2023-02-13 14:55 ` [PATCH 1/4] gdb/dwarf2: rename some things, index -> gdb_index Simon Marchi
2023-02-13 23:30   ` Tom Tromey
2023-02-14 19:55     ` Simon Marchi
2023-02-13 14:55 ` [PATCH 2/4] gdb/dwarf2: move some things to read.h Simon Marchi
2023-02-13 23:33   ` Tom Tromey
2023-02-14  2:24     ` Thiago Jung Bauermann
2023-02-14 19:35       ` Simon Marchi
2023-02-14 19:37     ` Simon Marchi
2023-02-13 14:55 ` [PATCH 3/4] gdb/dwarf2: split .gdb_index reading code to own file Simon Marchi
2023-02-13 23:35   ` Tom Tromey
2023-02-13 14:55 ` [PATCH 4/4] gdb/dwarf2: split .debug_names " Simon Marchi
2023-02-13 23:38   ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230213145559.46676-1-simon.marchi@polymtl.ca \
    --to=simon.marchi@polymtl.ca \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).