Re: [PATCH 2/4] gdb/dwarf2: move some things to read.h

[Tom Tromey <tom@tromey.com>]

>>>>> "Simon" == Simon Marchi via Gdb-patches <gdb-patches@sourceware.org> writes:

Simon> The following 2 patches move .gdb_index and .debug_names reading code to
Simon> their own file.  Prepare this by exposing some things used by that code
Simon> to read.h.

Simon> +/* If FILE_MATCHER is NULL or if PER_CU has
Simon> +   dwarf2_per_cu_quick_data::MARK set (see
Simon> +   dw_expand_symtabs_matching_file_matcher), expand the CU and call
Simon> +   EXPANSION_NOTIFY on it.  */
Simon> +
Simon> +bool
Simon> +dw2_expand_symtabs_matching_one
Simon> +  (dwarf2_per_cu_data *per_cu,
Simon> +   dwarf2_per_objfile *per_objfile,
Simon> +   gdb::function_view<expand_symtabs_file_matcher_ftype> file_matcher,
Simon> +   gdb::function_view<expand_symtabs_exp_notify_ftype> expansion_notify);

Don't we normally write "extern" in headers?

Also normally in declarations the type is on the same line as the
function name.

Simon> +/* This is a view into the index that converts from bytes to an
Simon> +   offset_type, and allows indexing.  Unaligned bytes are specifically
Simon> +   allowed here, and handled via unpacking.  */
Simon> +
Simon> +class offset_view
Simon> +{
Simon> +public:
Simon> +  offset_view () = default;

I think this type should be specific to .gdb_index.  It shouldn't be
needed anywhere else -- it's there to work around the lack of alignment.

If it is needed somewhere else, I suppose it's fine, it would just be
better to refactor so that this can be an implementation detail of
.gdb_index again.

Tom