Re: [PATCH 2/4] gdb/dwarf2: move some things to read.h

[Simon Marchi <simon.marchi@polymtl.ca>]

On 2/13/23 21:24, Thiago Jung Bauermann wrote:
> 
> Tom Tromey <tom@tromey.com> writes:
> 
>>>>>>> "Simon" == Simon Marchi via Gdb-patches <gdb-patches@sourceware.org> writes:
>>
>> Simon> The following 2 patches move .gdb_index and .debug_names reading code to
>> Simon> their own file.  Prepare this by exposing some things used by that code
>> Simon> to read.h.
>>
>> Simon> +/* If FILE_MATCHER is NULL or if PER_CU has
>> Simon> +   dwarf2_per_cu_quick_data::MARK set (see
>> Simon> +   dw_expand_symtabs_matching_file_matcher), expand the CU and call
>> Simon> +   EXPANSION_NOTIFY on it.  */
>> Simon> +
>> Simon> +bool
>> Simon> +dw2_expand_symtabs_matching_one
>> Simon> +  (dwarf2_per_cu_data *per_cu,
>> Simon> +   dwarf2_per_objfile *per_objfile,
>> Simon> +   gdb::function_view<expand_symtabs_file_matcher_ftype> file_matcher,
>> Simon> +   gdb::function_view<expand_symtabs_exp_notify_ftype> expansion_notify);
>>
>> Don't we normally write "extern" in headers?
> 
> IIUC “extern” is only meaningful for variable and template declarations.

For some reason, our coding standards says we should use extern for
function declarations:

https://sourceware.org/gdb/wiki/Internals%20GDB-C-Coding-Standards#Function_Prototypes

But I don't understand why, IMO it just consumes some columns for no
purpose.  Also, it's not always respected, there are many header files
that don't use it.

Simon