From: Simon Marchi <simon.marchi@efficios.com>
To: gdb-patches@sourceware.org
Cc: Simon Marchi <simon.marchi@efficios.com>
Subject: [pushed] gdb: revert one erroneous bool-ification change
Date: Mon, 20 Feb 2023 12:01:34 -0500 [thread overview]
Message-ID: <20230220170134.15548-1-simon.marchi@efficios.com> (raw)
Commit 42c13555ff88 ("Change value::m_stack to bool") erroneously
changed a `0` to `false` in this call to read_value_memory. This
parameter is `LONGEST bit_offset`, it should stay `0`.
Change-Id: I128df6834cf8055ec6a7051e237e379978d3d651
---
gdb/value.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/gdb/value.c b/gdb/value.c
index e52d1d77b48f..d2c2a2d7859b 100644
--- a/gdb/value.c
+++ b/gdb/value.c
@@ -3749,7 +3749,7 @@ value::fetch_lazy_memory ()
gdb_assert (len >= 0);
if (len > 0)
- read_value_memory (this, false, stack (), addr,
+ read_value_memory (this, 0, stack (), addr,
contents_all_raw ().data (), len);
}
--
2.39.1
reply other threads:[~2023-02-20 17:01 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230220170134.15548-1-simon.marchi@efficios.com \
--to=simon.marchi@efficios.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).