public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
* [pushed] gdb: revert one erroneous bool-ification change
@ 2023-02-20 17:01 Simon Marchi
  0 siblings, 0 replies; only message in thread
From: Simon Marchi @ 2023-02-20 17:01 UTC (permalink / raw)
  To: gdb-patches; +Cc: Simon Marchi

Commit 42c13555ff88 ("Change value::m_stack to bool") erroneously
changed a `0` to `false` in this call to read_value_memory.  This
parameter is `LONGEST bit_offset`, it should stay `0`.

Change-Id: I128df6834cf8055ec6a7051e237e379978d3d651
---
 gdb/value.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gdb/value.c b/gdb/value.c
index e52d1d77b48f..d2c2a2d7859b 100644
--- a/gdb/value.c
+++ b/gdb/value.c
@@ -3749,7 +3749,7 @@ value::fetch_lazy_memory ()
   gdb_assert (len >= 0);
 
   if (len > 0)
-    read_value_memory (this, false, stack (), addr,
+    read_value_memory (this, 0, stack (), addr,
 		       contents_all_raw ().data (), len);
 }
 
-- 
2.39.1


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2023-02-20 17:01 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-02-20 17:01 [pushed] gdb: revert one erroneous bool-ification change Simon Marchi

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).