From: Tom Tromey <tom@tromey.com>
To: gdb-patches@sourceware.org
Subject: [PATCH 5/5] Change linetable_entry::is_stmt to bool
Date: Wed, 08 Mar 2023 08:42:49 -0700 [thread overview]
Message-ID: <20230308-submit-constify-linetable-v1-5-ca4057478141@tromey.com> (raw)
In-Reply-To: <20230308-submit-constify-linetable-v1-0-ca4057478141@tromey.com>
This changes linetable_entry::is_stmt to type bool, rather than
unsigned.
---
gdb/jit.c | 2 +-
gdb/record-btrace.c | 2 +-
gdb/symtab.h | 2 +-
gdb/xcoffread.c | 4 ++--
4 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/gdb/jit.c b/gdb/jit.c
index b27df8a6e17..22ce7542c98 100644
--- a/gdb/jit.c
+++ b/gdb/jit.c
@@ -493,7 +493,7 @@ jit_symtab_line_mapping_add_impl (struct gdb_symbol_callbacks *cb,
{
stab->linetable->item[i].set_pc ((CORE_ADDR) map[i].pc);
stab->linetable->item[i].line = map[i].line;
- stab->linetable->item[i].is_stmt = 1;
+ stab->linetable->item[i].is_stmt = true;
}
}
diff --git a/gdb/record-btrace.c b/gdb/record-btrace.c
index 5b6e33f78fe..3e71c6c9a10 100644
--- a/gdb/record-btrace.c
+++ b/gdb/record-btrace.c
@@ -738,7 +738,7 @@ btrace_find_line_range (CORE_ADDR pc)
change was made I was unsure how to test this so chose to go with
maintaining the existing experience. */
if ((lines[i].raw_pc () == pc) && (lines[i].line != 0)
- && (lines[i].is_stmt == 1))
+ && lines[i].is_stmt)
range = btrace_line_range_add (range, lines[i].line);
}
diff --git a/gdb/symtab.h b/gdb/symtab.h
index 654da14e9a8..5c1b0611f9a 100644
--- a/gdb/symtab.h
+++ b/gdb/symtab.h
@@ -1575,7 +1575,7 @@ struct linetable_entry
int line;
/* True if this PC is a good location to place a breakpoint for LINE. */
- unsigned is_stmt : 1;
+ bool is_stmt : 1;
/* True if this location is a good location to place a breakpoint after a
function prologue. */
diff --git a/gdb/xcoffread.c b/gdb/xcoffread.c
index 45578311705..9a7606015e2 100644
--- a/gdb/xcoffread.c
+++ b/gdb/xcoffread.c
@@ -422,7 +422,7 @@ arrange_linetable (std::vector<linetable_entry> &old_linetable)
for (int ii = 0; ii < old_linetable.size (); ++ii)
{
- if (old_linetable[ii].is_stmt == 0)
+ if (!old_linetable[ii].is_stmt)
continue;
if (old_linetable[ii].line == 0)
@@ -431,7 +431,7 @@ arrange_linetable (std::vector<linetable_entry> &old_linetable)
fentries.emplace_back ();
linetable_entry &e = fentries.back ();
e.line = ii;
- e.is_stmt = 1;
+ e.is_stmt = true;
e.set_pc (old_linetable[ii].raw_pc ());
}
}
--
2.39.1
next prev parent reply other threads:[~2023-03-08 15:42 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-08 15:42 [PATCH 0/5] Make line tables independent of objfile Tom Tromey
2023-03-08 15:42 ` [PATCH 1/5] Add operator< and operator== to linetable_entry Tom Tromey
2023-03-11 3:21 ` Simon Marchi
2023-03-08 15:42 ` [PATCH 2/5] Change linetables to be objfile-independent Tom Tromey
2023-03-11 3:48 ` Simon Marchi
2023-03-11 15:36 ` Tom Tromey
2023-03-11 19:13 ` Simon Marchi
2023-03-12 3:24 ` Tom Tromey
2023-03-12 13:40 ` Simon Marchi
2023-03-16 14:02 ` Tom Tromey
2023-03-16 14:45 ` Simon Marchi
2023-03-16 23:43 ` Tom Tromey
2023-03-17 2:45 ` Simon Marchi
2023-03-17 13:09 ` Tom Tromey
2023-03-17 22:21 ` Tom Tromey
2023-03-20 14:57 ` Simon Marchi
2023-03-08 15:42 ` [PATCH 3/5] Constify linetables Tom Tromey
2023-03-08 15:42 ` [PATCH 4/5] Remove extra scopes from objfile_relocate1 Tom Tromey
2023-03-08 15:42 ` Tom Tromey [this message]
2023-03-11 3:51 ` [PATCH 0/5] Make line tables independent of objfile Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230308-submit-constify-linetable-v1-5-ca4057478141@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).