From: Tom Tromey <tom@tromey.com>
To: Simon Marchi <simark@simark.ca>
Cc: Tom Tromey <tom@tromey.com>,
Simon Marchi via Gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH 2/5] Change linetables to be objfile-independent
Date: Fri, 17 Mar 2023 07:09:26 -0600 [thread overview]
Message-ID: <877cvfcynt.fsf@tromey.com> (raw)
In-Reply-To: <0a02e351-0b13-c3b0-f324-b8e71ea44a7b@simark.ca> (Simon Marchi's message of "Thu, 16 Mar 2023 22:45:17 -0400")
Simon> https://review.lttng.org/c/binutils-gdb/+/9665
Lots of patches there!
#1 Renaming is fine but the "_raw" name was chosen to match psymtabs.
psymtabs are essentially obsolete now (depending on the state of the
stabs removal thread) but as long as they are around the naming should
match.
#2 Making a new header seems great to me.
#3 Ditto
#4 For this one I think my fix is better, it introduces a new type and
prevents this sort of bug.
#5 Looks good
Tom
next prev parent reply other threads:[~2023-03-17 13:09 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-08 15:42 [PATCH 0/5] Make line tables independent of objfile Tom Tromey
2023-03-08 15:42 ` [PATCH 1/5] Add operator< and operator== to linetable_entry Tom Tromey
2023-03-11 3:21 ` Simon Marchi
2023-03-08 15:42 ` [PATCH 2/5] Change linetables to be objfile-independent Tom Tromey
2023-03-11 3:48 ` Simon Marchi
2023-03-11 15:36 ` Tom Tromey
2023-03-11 19:13 ` Simon Marchi
2023-03-12 3:24 ` Tom Tromey
2023-03-12 13:40 ` Simon Marchi
2023-03-16 14:02 ` Tom Tromey
2023-03-16 14:45 ` Simon Marchi
2023-03-16 23:43 ` Tom Tromey
2023-03-17 2:45 ` Simon Marchi
2023-03-17 13:09 ` Tom Tromey [this message]
2023-03-17 22:21 ` Tom Tromey
2023-03-20 14:57 ` Simon Marchi
2023-03-08 15:42 ` [PATCH 3/5] Constify linetables Tom Tromey
2023-03-08 15:42 ` [PATCH 4/5] Remove extra scopes from objfile_relocate1 Tom Tromey
2023-03-08 15:42 ` [PATCH 5/5] Change linetable_entry::is_stmt to bool Tom Tromey
2023-03-11 3:51 ` [PATCH 0/5] Make line tables independent of objfile Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877cvfcynt.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=simark@simark.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).