From: Simon Marchi <simark@simark.ca>
To: Tom Tromey <tom@tromey.com>
Cc: Simon Marchi via Gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH 2/5] Change linetables to be objfile-independent
Date: Mon, 20 Mar 2023 10:57:18 -0400 [thread overview]
Message-ID: <7eea0b7e-bc77-3f9e-4062-77940970d952@simark.ca> (raw)
In-Reply-To: <87r0tnauj0.fsf@tromey.com>
On 3/17/23 18:21, Tom Tromey wrote:
> Tom> #1 Renaming is fine but the "_raw" name was chosen to match psymtabs.
>
> Well, I have this partly wrong, sorry about that.
>
> psymbols themselves use the other name:
>
> CORE_ADDR unrelocated_address () const
>
> but psymtabs use:
>
> CORE_ADDR raw_text_low () const
> CORE_ADDR raw_text_high () const
>
> and so do minsyms:
>
> CORE_ADDR value_raw_address () const
>
> I think one set or the other should be renamed. Which one do you
> prefer? I could go either way. Anyway let me know and I'll rename
> stuff.
I prefer "unrelocated", since it's a bit more specific and precise than
"raw". "raw" suggests that it's a value before some kind of processing,
but it doesn't tell which processing that it. With "unrelocated", you
know it's before relocation.
Simon
next prev parent reply other threads:[~2023-03-20 14:57 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-08 15:42 [PATCH 0/5] Make line tables independent of objfile Tom Tromey
2023-03-08 15:42 ` [PATCH 1/5] Add operator< and operator== to linetable_entry Tom Tromey
2023-03-11 3:21 ` Simon Marchi
2023-03-08 15:42 ` [PATCH 2/5] Change linetables to be objfile-independent Tom Tromey
2023-03-11 3:48 ` Simon Marchi
2023-03-11 15:36 ` Tom Tromey
2023-03-11 19:13 ` Simon Marchi
2023-03-12 3:24 ` Tom Tromey
2023-03-12 13:40 ` Simon Marchi
2023-03-16 14:02 ` Tom Tromey
2023-03-16 14:45 ` Simon Marchi
2023-03-16 23:43 ` Tom Tromey
2023-03-17 2:45 ` Simon Marchi
2023-03-17 13:09 ` Tom Tromey
2023-03-17 22:21 ` Tom Tromey
2023-03-20 14:57 ` Simon Marchi [this message]
2023-03-08 15:42 ` [PATCH 3/5] Constify linetables Tom Tromey
2023-03-08 15:42 ` [PATCH 4/5] Remove extra scopes from objfile_relocate1 Tom Tromey
2023-03-08 15:42 ` [PATCH 5/5] Change linetable_entry::is_stmt to bool Tom Tromey
2023-03-11 3:51 ` [PATCH 0/5] Make line tables independent of objfile Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7eea0b7e-bc77-3f9e-4062-77940970d952@simark.ca \
--to=simark@simark.ca \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).