From: Tom de Vries <tdevries@suse.de>
To: gdb-patches@sourceware.org
Subject: [pushed 4/8] [gdb/testsuite] Fix gdb.tui/tui-nl-filtered-output.exp for remote host
Date: Mon, 13 Mar 2023 17:20:47 +0100 [thread overview]
Message-ID: <20230313162051.488-5-tdevries@suse.de> (raw)
In-Reply-To: <20230313162051.488-1-tdevries@suse.de>
When running test-case gdb.tui/tui-nl-filtered-output.exp with host board
local-remote-host-notty and target board native-gdbserver, I get:
...
FAIL: gdb.tui/tui-nl-filtered-output.exp: check printf output
...
The problem is that Term::enter_tui is returning 0, but the test-case doesn't
check for this, and consequently runs unsupported tests.
Fix this by adding the missing check.
Tested on x86_64-linux.
---
gdb/testsuite/gdb.tui/tui-nl-filtered-output.exp | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/gdb/testsuite/gdb.tui/tui-nl-filtered-output.exp b/gdb/testsuite/gdb.tui/tui-nl-filtered-output.exp
index 5b1d6b7d9ba..8f85ae7ce49 100644
--- a/gdb/testsuite/gdb.tui/tui-nl-filtered-output.exp
+++ b/gdb/testsuite/gdb.tui/tui-nl-filtered-output.exp
@@ -36,7 +36,10 @@ tuiterm_env
# Setup and enter TUI mode.
Term::clean_restart 24 80
-Term::enter_tui
+if {![Term::enter_tui]} {
+ unsupported "TUI not supported"
+ return
+}
# Send the command, and check the output is correctly split over
# multiple lines.
--
2.35.3
next prev parent reply other threads:[~2023-03-13 16:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-13 16:20 [pushed 0/8] [gdb/testsuite] Fix remote host issues in TUI tests Tom de Vries
2023-03-13 16:20 ` [pushed 1/8] [gdb/testsuite] Fix untested message in gdb.tui/corefile-run.exp Tom de Vries
2023-03-13 16:20 ` [pushed 2/8] [gdb/testsuite] Handle USE_TUI " Tom de Vries
2023-03-13 16:20 ` [pushed 3/8] [gdb/testsuite] Require ![is_remote host] for TUI Tom de Vries
2023-03-13 16:20 ` Tom de Vries [this message]
2023-03-13 16:20 ` [pushed 5/8] [gdb/testsuite] Fix gdb.tui/tui-layout.exp for remote host Tom de Vries
2023-03-13 16:20 ` [pushed 6/8] [gdb/testsuite] Fix gdb.tui/completion.exp for local-remote-host-notty Tom de Vries
2023-03-13 16:20 ` [pushed 7/8] [gdb/testsuite] Fix gdb.python/tui-window.exp for remote host Tom de Vries
2023-03-13 16:20 ` [pushed 8/8] [gdb/testsuite] Fix gdb.python/tui-window-factory.exp " Tom de Vries
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230313162051.488-5-tdevries@suse.de \
--to=tdevries@suse.de \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).