[PATCH 0/1] Remove redundant ERROR_NO_INFERIOR in continue_command

[PATCH 0/1] Remove redundant ERROR_NO_INFERIOR in continue_command

[Christina Schimpe]

Hi all,

this patch was originally written by Nils-Christian Kempke.
I just rebased it onto current master and adapted the commit message.

Regards,
Christina

Nils-Christian Kempke (1):
  gdb, infcmd: remove redundant ERROR_NO_INFERIOR in continue_command

 gdb/infcmd.c | 1 -
 1 file changed, 1 deletion(-)

-- 
2.25.1

Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de>
Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva  
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928

[PATCH 1/1] gdb, infcmd: remove redundant ERROR_NO_INFERIOR in continue_command

[Christina Schimpe]

From: Nils-Christian Kempke <nils-christian.kempke@intel.com>

The ERROR_NO_INFERIOR macro is already called at the beginning of the
function.  Since target/inferior are not switched in-between, the second
call to it is redundant.

Co-Authored-By: Christina Schimpe <christina.schimpe@intel.com>
---
 gdb/infcmd.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/gdb/infcmd.c b/gdb/infcmd.c
index c369b795757..abe9c933c9a 100644
--- a/gdb/infcmd.c
+++ b/gdb/infcmd.c
@@ -735,7 +735,6 @@ continue_command (const char *args, int from_tty)
 	}
     }
 
-  ERROR_NO_INFERIOR;
   ensure_not_tfind_mode ();
 
   if (!non_stop || !all_threads_p)
-- 
2.25.1

Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de>
Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva  
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928

Re: [PATCH 1/1] gdb, infcmd: remove redundant ERROR_NO_INFERIOR in continue_command

[Alexandra Petlanova Hajkova]

[-- Attachment #1: Type: text/plain, Size: 1320 bytes --]

On Mon, Mar 13, 2023 at 7:01 PM Christina Schimpe via Gdb-patches <
gdb-patches@sourceware.org> wrote:

> From: Nils-Christian Kempke <nils-christian.kempke@intel.com>
>
> The ERROR_NO_INFERIOR macro is already called at the beginning of the
> function.  Since target/inferior are not switched in-between, the second
> call to it is redundant.
>
> Co-Authored-By: Christina Schimpe <christina.schimpe@intel.com>
> ---
>  gdb/infcmd.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/gdb/infcmd.c b/gdb/infcmd.c
> index c369b795757..abe9c933c9a 100644
> --- a/gdb/infcmd.c
> +++ b/gdb/infcmd.c
> @@ -735,7 +735,6 @@ continue_command (const char *args, int from_tty)
>         }
>      }
>
> -  ERROR_NO_INFERIOR;
>    ensure_not_tfind_mode ();
>
>    if (!non_stop || !all_threads_p)
> --
> 2.25.1
>
> Intel Deutschland GmbH
> Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
> Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de>
> Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva
> Chairperson of the Supervisory Board: Nicole Lau
> Registered Office: Munich
> Commercial Register: Amtsgericht Muenchen HRB 186928
>

Looks correct. Maybe you could mention this happens inside the
continue_command function in the commit message.