From: Christina Schimpe <christina.schimpe@intel.com>
To: gdb-patches@sourceware.org
Cc: eliz@gnu.org, blarsen@redhat.com, simark@simark.ca,
Christina Schimpe <christina.schimpe@intel.com>
Subject: [PATCH v3 1/1] gdb, breakpoint: add breakpoint location debugging logs
Date: Mon, 27 Mar 2023 11:12:35 +0200 [thread overview]
Message-ID: <20230327091235.521536-2-christina.schimpe@intel.com> (raw)
In-Reply-To: <20230327091235.521536-1-christina.schimpe@intel.com>
From: Mihails Strasuns <mihails.strasuns@intel.com>
Add new commands:
set debug breakpoints on|off
show debug breakpoints
This patch introduces new debugging information that prints
breakpoint location insertion and removal flow.
The debug output looks like:
~~~
(gdb) set debug breakpoints on
(gdb) disassemble main
Dump of assembler code for function main:
0x0000555555555129 <+0>: endbr64
0x000055555555512d <+4>: push %rbp
0x000055555555512e <+5>: mov %rsp,%rbp
=> 0x0000555555555131 <+8>: mov $0x0,%eax
0x0000555555555136 <+13>: pop %rbp
0x0000555555555137 <+14>: ret
End of assembler dump.
(gdb) break *0x0000555555555137
Breakpoint 2 at 0x555555555137: file main.c, line 4.
[breakpoints] update_global_location_list: insert_mode = UGLL_MAY_INSERT
(gdb) c
Continuing.
[breakpoints] update_global_location_list: insert_mode = UGLL_INSERT
[breakpoints] insert_bp_location: bp_location (0x55d3881c1e20) at address 0x555555555137 in main at main.c:4
[breakpoints] insert_bp_location: bp_location (0x55d38827d670) at address 0x7ffff7fd37b5
[breakpoints] insert_bp_location: bp_location (0x55d388295880) at address 0x7ffff7fe509e
[breakpoints] insert_bp_location: bp_location (0x55d388295e00) at address 0x7ffff7fe63f4
[breakpoints] remove_breakpoint_1: bp_location (0x55d3881c1e20) due to regular remove at address 0x555555555137 in main at main.c:4
[breakpoints] remove_breakpoint_1: bp_location (0x55d38827d670) due to regular remove at address 0x7ffff7fd37b5
[breakpoints] remove_breakpoint_1: bp_location (0x55d388295880) due to regular remove at address 0x7ffff7fe509e
[breakpoints] remove_breakpoint_1: bp_location (0x55d388295e00) due to regular remove at address 0x7ffff7fe63f4
Breakpoint 2, 0x0000555555555137 in main () at main.c:4
4 }
~~~
Co-Authored-By: Christina Schimpe <christina.schimpe@intel.com>
---
gdb/NEWS | 4 +++
gdb/breakpoint.c | 73 +++++++++++++++++++++++++++++++++++++++++++++
gdb/doc/gdb.texinfo | 8 +++++
3 files changed, 85 insertions(+)
diff --git a/gdb/NEWS b/gdb/NEWS
index cc262f1f8a6..f413cd5aeb4 100644
--- a/gdb/NEWS
+++ b/gdb/NEWS
@@ -3,6 +3,10 @@
*** Changes since GDB 13
+* set debug breakpoints on|off
+ show debug breakpoints
+ Print additional debug messages about breakpoint insertion and removal.
+
* Removed targets and native configurations
GDB no longer supports AIX 4.x, AIX 5.x and AIX 6.x. The minimum supported
diff --git a/gdb/breakpoint.c b/gdb/breakpoint.c
index 7228acfd8fe..8db810fd465 100644
--- a/gdb/breakpoint.c
+++ b/gdb/breakpoint.c
@@ -163,6 +163,8 @@ static bool bl_address_is_meaningful (bp_location *loc);
static int find_loc_num_by_location (const bp_location *loc);
+static std::string breakpoint_location_to_buffer (bp_location *bl);
+
/* update_global_location_list's modes of operation wrt to whether to
insert locations now. */
enum ugll_insert_mode
@@ -198,6 +200,24 @@ enum ugll_insert_mode
UGLL_INSERT
};
+/* Return a textual version of INSERT_MODE. */
+
+static const char *
+ugll_insert_mode_text (ugll_insert_mode insert_mode)
+{
+ switch (insert_mode)
+ {
+ case UGLL_DONT_INSERT:
+ return "UGLL_DONT_INSERT";
+ case UGLL_MAY_INSERT:
+ return "UGLL_MAY_INSERT";
+ case UGLL_INSERT:
+ return "UGLL_INSERT";
+ }
+
+ gdb_assert_not_reached ("must handle all enum values");
+}
+
static void update_global_location_list (enum ugll_insert_mode);
static void update_global_location_list_nothrow (enum ugll_insert_mode);
@@ -508,6 +528,22 @@ show_always_inserted_mode (struct ui_file *file, int from_tty,
value);
}
+/* True if breakpoints debug output is enabled. */
+static bool debug_breakpoints = false;
+
+/* Print a "breakpoints" debug statement. */
+#define breakpoint_debug_printf(fmt, ...) \
+ debug_prefixed_printf_cond (debug_breakpoints, "breakpoints", fmt, \
+ ##__VA_ARGS__)
+
+/* "show debug breakpoints" implementation. */
+static void
+show_debug_breakpoints (struct ui_file *file, int from_tty,
+ struct cmd_list_element *c, const char *value)
+{
+ gdb_printf (file, _("Breakpoint location debugging is %s.\n"), value);
+}
+
/* See breakpoint.h. */
int
@@ -2710,6 +2746,11 @@ insert_bp_location (struct bp_location *bl,
if (!should_be_inserted (bl) || (bl->inserted && !bl->needs_update))
return 0;
+ breakpoint_debug_printf ("bp_location (%s) at address %s %s",
+ host_address_to_string (bl),
+ paddress (bl->gdbarch, bl->address),
+ breakpoint_location_to_buffer (bl).c_str ());
+
/* Note we don't initialize bl->target_info, as that wipes out
the breakpoint location's shadow_contents if the breakpoint
is still inserted at that location. This in turn breaks
@@ -3264,6 +3305,8 @@ remove_breakpoints_inf (inferior *inf)
{
int val;
+ breakpoint_debug_printf ("inf->num = %d", inf->num);
+
for (bp_location *bl : all_bp_locations ())
{
if (bl->pspace != inf->pspace)
@@ -3908,6 +3951,13 @@ detach_breakpoints (ptid_t ptid)
static int
remove_breakpoint_1 (struct bp_location *bl, enum remove_bp_reason reason)
{
+ breakpoint_debug_printf ("bp_location (%s) due to %s at address %s %s",
+ host_address_to_string (bl),
+ (reason == REMOVE_BREAKPOINT
+ ? "regular remove" : "detach"),
+ paddress (bl->gdbarch, bl->address),
+ breakpoint_location_to_buffer (bl).c_str ());
+
int val;
/* BL is never in moribund_locations by our callers. */
@@ -6210,6 +6260,17 @@ print_breakpoint_location (const breakpoint *b,
}
}
+/* Return the output of the print_breakpoint_location BL as a string. */
+static std::string
+breakpoint_location_to_buffer (bp_location *bl)
+{
+ string_file stb;
+ current_uiout->redirect (&stb);
+ print_breakpoint_location (bl->owner, bl);
+ current_uiout->redirect (nullptr);
+ return stb.string ();
+}
+
static const char *
bptype_string (enum bptype type)
{
@@ -11147,6 +11208,9 @@ update_global_location_list (enum ugll_insert_mode insert_mode)
/* Last breakpoint location program space that was marked for update. */
int last_pspace_num = -1;
+ breakpoint_debug_printf ("insert_mode = %s",
+ ugll_insert_mode_text (insert_mode));
+
/* Used in the duplicates detection below. When iterating over all
bp_locations, points to the first bp_location of a given address.
Breakpoints and watchpoints of different types are never
@@ -14880,6 +14944,15 @@ when execution stops."),
&breakpoint_set_cmdlist,
&breakpoint_show_cmdlist);
+ add_setshow_boolean_cmd ("breakpoints", class_maintenance,
+ &debug_breakpoints, _("\
+Set breakpoint location debugging."), _("\
+Show breakpoint location debugging."), _("\
+When non-zero, breakpoint location specific debugging is enabled."),
+ NULL,
+ show_debug_breakpoints,
+ &setdebuglist, &showdebuglist);
+
add_setshow_enum_cmd ("condition-evaluation", class_breakpoint,
condition_evaluation_enums,
&condition_evaluation_mode_1, _("\
diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo
index 6c811b8be2e..04e77350da1 100644
--- a/gdb/doc/gdb.texinfo
+++ b/gdb/doc/gdb.texinfo
@@ -28315,6 +28315,14 @@ debugging info.
Turn on or off debugging messages for built-in XML parsers.
@item show debug xml
Displays the current state of XML debugging messages.
+
+@item set debug breakpoints
+@cindex breakpoint debugging info
+Turns on or off display of @value{GDBN} debugging info for breakpoint insertion
+and removal. The default is off.
+@item show debug breakpoints
+Displays the current state of displaying @value{GDBN} debugging info for
+breakpoint insertion and removal.
@end table
@node Other Misc Settings
--
2.25.1
Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de>
Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928
next prev parent reply other threads:[~2023-03-27 9:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-27 9:12 [PATCH v3 0/1] Add " Christina Schimpe
2023-03-27 9:12 ` Christina Schimpe [this message]
2023-03-27 14:10 ` [PATCH v3 1/1] gdb, breakpoint: add " Andrew Burgess
2023-06-01 13:05 ` Schimpe, Christina
2023-03-27 14:47 ` Simon Marchi
2023-06-01 13:11 ` Schimpe, Christina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230327091235.521536-2-christina.schimpe@intel.com \
--to=christina.schimpe@intel.com \
--cc=blarsen@redhat.com \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=simark@simark.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).