RE: [PATCH v3 1/1] gdb, breakpoint: add breakpoint location debugging logs

["Schimpe, Christina" <christina.schimpe@intel.com>]

Hi Simon, 

Thanks a lot for your review.

> Another little nit: for consistency, let's add a remove_bp_reason_str function to
> convert an enum remove_bp_reason to a string (same as you did for
> ugll_insert_mode).  This way we'll get an assertion failure if we add a new
> enumerator and for got to handle it in the switch.
> 
> And for all functions of this kind, I would be tempted to use
> DIAGNOSTIC_ERROR_SWITCH, like we have in the target_waitkind_str), so that
> compilers that support it can warn if we miss an enumerator in the switch.


Your comments make sense to me, I will post a v4 soon.

Christina
Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de>
Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva  
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928