Re: [PATCH v3 1/1] gdb, breakpoint: add breakpoint location debugging logs

[Simon Marchi <simark@simark.ca>]

> @@ -3908,6 +3951,13 @@ detach_breakpoints (ptid_t ptid)
>  static int
>  remove_breakpoint_1 (struct bp_location *bl, enum remove_bp_reason reason)
>  {
> +  breakpoint_debug_printf ("bp_location (%s) due to %s at address %s %s",
> +			   host_address_to_string (bl),
> +			   (reason == REMOVE_BREAKPOINT
> +			     ? "regular remove" : "detach"),
Another little nit: for consistency, let's add a remove_bp_reason_str
function to convert an enum remove_bp_reason to a string (same as you
did for ugll_insert_mode).  This way we'll get an assertion failure if
we add a new enumerator and for got to handle it in the switch.

And for all functions of this kind, I would be tempted to use
DIAGNOSTIC_ERROR_SWITCH, like we have in the target_waitkind_str), so
that compilers that support it can warn if we miss an enumerator in the
switch.

Simon