[PATCH v2 0/1] Remove redundant ERROR_NO_INFERIOR in continue_command

[PATCH v2 0/1] Remove redundant ERROR_NO_INFERIOR in continue_command

[Christina Schimpe]

Hi all,

this is my v2 for the patch
"gdb, infcmd: remove redundant ERROR_NO_INFERIOR in continue_command".
The patch was originally written by Nils-Christian Kempke.
Since v1 I just enhanced the commit message based on the feedback of Alexandra.

V1 of this patch can be found here: 
https://sourceware.org/pipermail/gdb-patches/2023-March/197897.html

Regards,
Christina

Nils-Christian Kempke (1):
  gdb, infcmd: remove redundant ERROR_NO_INFERIOR in continue_command

 gdb/infcmd.c | 1 -
 1 file changed, 1 deletion(-)

-- 
2.25.1

Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de>
Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva  
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928

[PATCH v2 1/1] gdb, infcmd: remove redundant ERROR_NO_INFERIOR in continue_command

[Christina Schimpe]

From: Nils-Christian Kempke <nils-christian.kempke@intel.com>

The ERROR_NO_INFERIOR macro is already called at the beginning of the
function continue_command.  Since target/inferior are not switched in-between,
the second call to it is redundant.

Co-Authored-By: Christina Schimpe <christina.schimpe@intel.com>
---
 gdb/infcmd.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/gdb/infcmd.c b/gdb/infcmd.c
index e2032d18564..a68611538f2 100644
--- a/gdb/infcmd.c
+++ b/gdb/infcmd.c
@@ -735,7 +735,6 @@ continue_command (const char *args, int from_tty)
 	}
     }
 
-  ERROR_NO_INFERIOR;
   ensure_not_tfind_mode ();
 
   if (!non_stop || !all_threads_p)
-- 
2.25.1

Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de>
Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva  
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928

Re: [PATCH v2 1/1] gdb, infcmd: remove redundant ERROR_NO_INFERIOR in continue_command

[Alexandra Petlanova Hajkova]

[-- Attachment #1: Type: text/plain, Size: 465 bytes --]

On Mon, Mar 27, 2023 at 11:55 AM Christina Schimpe <
christina.schimpe@intel.com> wrote:

> From: Nils-Christian Kempke <nils-christian.kempke@intel.com>
>
> The ERROR_NO_INFERIOR macro is already called at the beginning of the
> function continue_command.  Since target/inferior are not switched
> in-between,
> the second call to it is redundant.
>
> Co-Authored-By: Christina Schimpe <christina.schimpe@intel.com>
>
>
I think it's good to go in.

Re: [PATCH v2 1/1] gdb, infcmd: remove redundant ERROR_NO_INFERIOR in continue_command

[Andrew Burgess]

Christina Schimpe via Gdb-patches <gdb-patches@sourceware.org> writes:

> From: Nils-Christian Kempke <nils-christian.kempke@intel.com>
>
> The ERROR_NO_INFERIOR macro is already called at the beginning of the
> function continue_command.  Since target/inferior are not switched in-between,
> the second call to it is redundant.
>
> Co-Authored-By: Christina Schimpe <christina.schimpe@intel.com>

Approved-By: Andrew Burgess <aburgess@redhat.com>

Thanks,
Andrew

> ---
>  gdb/infcmd.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/gdb/infcmd.c b/gdb/infcmd.c
> index e2032d18564..a68611538f2 100644
> --- a/gdb/infcmd.c
> +++ b/gdb/infcmd.c
> @@ -735,7 +735,6 @@ continue_command (const char *args, int from_tty)
>  	}
>      }
>  
> -  ERROR_NO_INFERIOR;
>    ensure_not_tfind_mode ();
>  
>    if (!non_stop || !all_threads_p)
> -- 
> 2.25.1
>
> Intel Deutschland GmbH
> Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
> Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de>
> Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva  
> Chairperson of the Supervisory Board: Nicole Lau
> Registered Office: Munich
> Commercial Register: Amtsgericht Muenchen HRB 186928

RE: [PATCH v2 1/1] gdb, infcmd: remove redundant ERROR_NO_INFERIOR in continue_command

[Schimpe, Christina]

Thank you for the review, I pushed this.

Christina

> -----Original Message-----
> From: Andrew Burgess <aburgess@redhat.com>
> Sent: Monday, March 27, 2023 3:31 PM
> To: Christina Schimpe via Gdb-patches <gdb-patches@sourceware.org>;
> gdb-patches@sourceware.org
> Cc: ahajkova@redhat.com; Schimpe, Christina
> <christina.schimpe@intel.com>
> Subject: Re: [PATCH v2 1/1] gdb, infcmd: remove redundant
> ERROR_NO_INFERIOR in continue_command
> 
> Christina Schimpe via Gdb-patches <gdb-patches@sourceware.org> writes:
> 
> > From: Nils-Christian Kempke <nils-christian.kempke@intel.com>
> >
> > The ERROR_NO_INFERIOR macro is already called at the beginning of the
> > function continue_command.  Since target/inferior are not switched
> > in-between, the second call to it is redundant.
> >
> > Co-Authored-By: Christina Schimpe <christina.schimpe@intel.com>
> 
> Approved-By: Andrew Burgess <aburgess@redhat.com>
> 
> Thanks,
> Andrew
> 
> > ---
> >  gdb/infcmd.c | 1 -
> >  1 file changed, 1 deletion(-)
> >
> > diff --git a/gdb/infcmd.c b/gdb/infcmd.c index
> > e2032d18564..a68611538f2 100644
> > --- a/gdb/infcmd.c
> > +++ b/gdb/infcmd.c
> > @@ -735,7 +735,6 @@ continue_command (const char *args, int from_tty)
> >  	}
> >      }
> >
> > -  ERROR_NO_INFERIOR;
> >    ensure_not_tfind_mode ();
> >
> >    if (!non_stop || !all_threads_p)
> > --
> > 2.25.1
> >
> > Intel Deutschland GmbH
> > Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
> > Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de> Managing
> > Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva
> > Chairperson of the Supervisory Board: Nicole Lau Registered Office:
> > Munich Commercial Register: Amtsgericht Muenchen HRB 186928

Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de>
Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva  
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928