* [PATCH V2 4/5] gdb/testsuite: Disable some tests that are broken on remote Windows host
@ 2023-04-23 19:36 Sandra Loosemore
2023-04-23 19:36 ` [PATCH V2 5/5] gdb/testsuite: Make hook-stop.exp ignore termination message from GDB stub Sandra Loosemore
0 siblings, 1 reply; 2+ messages in thread
From: Sandra Loosemore @ 2023-04-23 19:36 UTC (permalink / raw)
To: gdb-patches; +Cc: tom
These testcases assume host==build or that the remote host has a Posix
shell to run commands in. Don't try to run them if that's not the case.
---
gdb/testsuite/gdb.base/bad-file.exp | 3 +++
gdb/testsuite/gdb.base/early-init-file.exp | 3 +++
gdb/testsuite/gdb.base/empty-host-env-vars.exp | 3 +++
3 files changed, 9 insertions(+)
diff --git a/gdb/testsuite/gdb.base/bad-file.exp b/gdb/testsuite/gdb.base/bad-file.exp
index 5d8dfee8fea..5e050411f95 100644
--- a/gdb/testsuite/gdb.base/bad-file.exp
+++ b/gdb/testsuite/gdb.base/bad-file.exp
@@ -20,6 +20,9 @@
# print different text then the plan is to update the expected text
# instead of making this test linux-only or some such.
+# The pathnames and shell commands in this test don't work on Windows host.
+require {!ishost *-*-mingw*}
+
# There is no such file, but we still use the normal mechanism to pick
# its name and path.
standard_testfile
diff --git a/gdb/testsuite/gdb.base/early-init-file.exp b/gdb/testsuite/gdb.base/early-init-file.exp
index fcd1ff041a1..237439f9db7 100644
--- a/gdb/testsuite/gdb.base/early-init-file.exp
+++ b/gdb/testsuite/gdb.base/early-init-file.exp
@@ -15,6 +15,9 @@
# Test GDB's early init file mechanism.
+# Test assumes host == build.
+require {!is_remote host}
+
standard_testfile
# Compile the test executable.
diff --git a/gdb/testsuite/gdb.base/empty-host-env-vars.exp b/gdb/testsuite/gdb.base/empty-host-env-vars.exp
index 96240311c24..22f6b4d2ebe 100644
--- a/gdb/testsuite/gdb.base/empty-host-env-vars.exp
+++ b/gdb/testsuite/gdb.base/empty-host-env-vars.exp
@@ -13,6 +13,9 @@
# You should have received a copy of the GNU General Public License
# along with this program. If not, see <http://www.gnu.org/licenses/>.
+# This test assumes host == build.
+require {!is_remote host}
+
# GDB reads some environment variables on startup, make sure it behaves
# correctly if these variables are defined but empty.
--
2.31.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* [PATCH V2 5/5] gdb/testsuite: Make hook-stop.exp ignore termination message from GDB stub
2023-04-23 19:36 [PATCH V2 4/5] gdb/testsuite: Disable some tests that are broken on remote Windows host Sandra Loosemore
@ 2023-04-23 19:36 ` Sandra Loosemore
0 siblings, 0 replies; 2+ messages in thread
From: Sandra Loosemore @ 2023-04-23 19:36 UTC (permalink / raw)
To: gdb-patches; +Cc: tom
When a GDB stub is run via "target remote |", it sometimes produces
extra output that ends up mixed with GDB's own output. For example,
QEMU's built-in GDB stub responds to the vKill packet by printing
nios2-elf-qemu-system: QEMU: Terminated via GDBstub
before exiting.
This patch fixes the regexp in gdb.base/hook-stop.exp to allow such
messages between GDB's "continuing" and "Inferior killed" messages.
---
gdb/testsuite/gdb.base/hook-stop.exp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/gdb/testsuite/gdb.base/hook-stop.exp b/gdb/testsuite/gdb.base/hook-stop.exp
index 0babd46aaea..50c5dfe9dc5 100644
--- a/gdb/testsuite/gdb.base/hook-stop.exp
+++ b/gdb/testsuite/gdb.base/hook-stop.exp
@@ -85,7 +85,7 @@ proc hook_stop_kill {} {
set test "run hook-stop"
gdb_test_multiple "continue" "$test" {
- -re "Continuing.\r\n\\\[Inferior $decimal \\(.*\\) killed\\\]\r\n${gdb_prompt} $" {
+ -re "Continuing.*\r\n\\\[Inferior $decimal \\(.*\\) killed\\\]\r\n${gdb_prompt} $" {
pass $test
}
}
--
2.31.1
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-04-23 19:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-04-23 19:36 [PATCH V2 4/5] gdb/testsuite: Disable some tests that are broken on remote Windows host Sandra Loosemore
2023-04-23 19:36 ` [PATCH V2 5/5] gdb/testsuite: Make hook-stop.exp ignore termination message from GDB stub Sandra Loosemore
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).