From: Tom de Vries <tdevries@suse.de>
To: gdb-patches@sourceware.org
Subject: [pushed] [gdb/testsuite] Skip dap tests for tcl 8.5
Date: Mon, 24 Apr 2023 11:29:53 +0200 [thread overview]
Message-ID: <20230424092953.19953-1-tdevries@suse.de> (raw)
When running the dap tests on a system with tcl 8.5, we run into:
...
ERROR: tcl error sourcing gdb/testsuite/gdb.dap/memory.exp.
ERROR: bad class "entier": must be alnum, alpha, ascii, control, boolean, \
digit, double, false, graph, integer, list, lower, print, punct, space, \
true, upper, wideinteger, wordchar, or xdigit
while executing
"string is entier $num"
(procedure "num" line 16)
invoked from within
...
Fix this by:
- requiring tcl 8.6 in allow_dap_tests, and
- adding the missing require allow_dap_tests in gdb.dap/memory.exp.
Tested on x86_64-linux.
---
gdb/testsuite/gdb.dap/memory.exp | 2 ++
gdb/testsuite/lib/gdb.exp | 5 +++++
2 files changed, 7 insertions(+)
diff --git a/gdb/testsuite/gdb.dap/memory.exp b/gdb/testsuite/gdb.dap/memory.exp
index fec552c4124..ab0516d6b3d 100644
--- a/gdb/testsuite/gdb.dap/memory.exp
+++ b/gdb/testsuite/gdb.dap/memory.exp
@@ -15,6 +15,8 @@
# Test DAP read/write memory.
+require allow_dap_tests
+
load_lib dap-support.exp
standard_testfile
diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp
index 9ea0334759d..b59b4358ca4 100644
--- a/gdb/testsuite/lib/gdb.exp
+++ b/gdb/testsuite/lib/gdb.exp
@@ -2515,6 +2515,11 @@ gdb_caching_proc allow_dap_tests {} {
return 0
}
+ # ton.tcl uses "string is entier", supported starting tcl 8.6.
+ if { ![tcl_version_at_least 8 6] } {
+ return 0
+ }
+
# With set auto-connect-native-target off, we run into:
# +++ run
# Traceback (most recent call last):
base-commit: d4a174a5cbb794143164897a4e8a08972fd251a1
--
2.35.3
reply other threads:[~2023-04-24 9:29 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230424092953.19953-1-tdevries@suse.de \
--to=tdevries@suse.de \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).