* [pushed] [gdb/testsuite] Skip dap tests for tcl 8.5
@ 2023-04-24 9:29 Tom de Vries
0 siblings, 0 replies; only message in thread
From: Tom de Vries @ 2023-04-24 9:29 UTC (permalink / raw)
To: gdb-patches
When running the dap tests on a system with tcl 8.5, we run into:
...
ERROR: tcl error sourcing gdb/testsuite/gdb.dap/memory.exp.
ERROR: bad class "entier": must be alnum, alpha, ascii, control, boolean, \
digit, double, false, graph, integer, list, lower, print, punct, space, \
true, upper, wideinteger, wordchar, or xdigit
while executing
"string is entier $num"
(procedure "num" line 16)
invoked from within
...
Fix this by:
- requiring tcl 8.6 in allow_dap_tests, and
- adding the missing require allow_dap_tests in gdb.dap/memory.exp.
Tested on x86_64-linux.
---
gdb/testsuite/gdb.dap/memory.exp | 2 ++
gdb/testsuite/lib/gdb.exp | 5 +++++
2 files changed, 7 insertions(+)
diff --git a/gdb/testsuite/gdb.dap/memory.exp b/gdb/testsuite/gdb.dap/memory.exp
index fec552c4124..ab0516d6b3d 100644
--- a/gdb/testsuite/gdb.dap/memory.exp
+++ b/gdb/testsuite/gdb.dap/memory.exp
@@ -15,6 +15,8 @@
# Test DAP read/write memory.
+require allow_dap_tests
+
load_lib dap-support.exp
standard_testfile
diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp
index 9ea0334759d..b59b4358ca4 100644
--- a/gdb/testsuite/lib/gdb.exp
+++ b/gdb/testsuite/lib/gdb.exp
@@ -2515,6 +2515,11 @@ gdb_caching_proc allow_dap_tests {} {
return 0
}
+ # ton.tcl uses "string is entier", supported starting tcl 8.6.
+ if { ![tcl_version_at_least 8 6] } {
+ return 0
+ }
+
# With set auto-connect-native-target off, we run into:
# +++ run
# Traceback (most recent call last):
base-commit: d4a174a5cbb794143164897a4e8a08972fd251a1
--
2.35.3
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2023-04-24 9:29 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-04-24 9:29 [pushed] [gdb/testsuite] Skip dap tests for tcl 8.5 Tom de Vries
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).