public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
* [pushed] [gdb/build] Fix build without ncurses in maintenance_info_screen
@ 2023-04-29  5:04 Tom de Vries
  0 siblings, 0 replies; only message in thread
From: Tom de Vries @ 2023-04-29  5:04 UTC (permalink / raw)
  To: gdb-patches

With a build without ncurses we run into:
...
src/gdb/utils.c: In function ‘void maintenance_info_screen(const char*, int)’:
src/gdb/utils.c:1310:7: error: ‘COLS’ was not declared in this scope
       COLS);
       ^~~~
src/gdb/utils.c:1331:8: error: ‘LINES’ was not declared in this scope
        LINES);
        ^~~~~
...

Fix this by using HAVE_LIBCURSES.

Tested on x86_64-linux.

PR build/30391
Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=30391
---
 gdb/utils.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/gdb/utils.c b/gdb/utils.c
index b5bb84ce85d..002a5885aff 100644
--- a/gdb/utils.c
+++ b/gdb/utils.c
@@ -1304,10 +1304,12 @@ maintenance_info_screen (const char *args, int from_tty)
 		  ? " (unlimited - 1)"
 		  : "")));
 
+#ifdef HAVE_LIBCURSES
   gdb_printf (gdb_stdout,
 	     _("Number of characters curses thinks "
 	       "are in a line is %d.\n"),
 	     COLS);
+#endif
 
   gdb_printf (gdb_stdout,
 	      _("Number of characters environment thinks "
@@ -1325,10 +1327,12 @@ maintenance_info_screen (const char *args, int from_tty)
 	      rows,
 	      rows == sqrt_int_max ? " (unlimited)" : "");
 
+#ifdef HAVE_LIBCURSES
   gdb_printf (gdb_stdout,
 	     _("Number of lines curses thinks "
 	       "are in a page is %d.\n"),
 	      LINES);
+#endif
 
   gdb_printf (gdb_stdout,
 	      _("Number of lines environment thinks "

base-commit: 1b05f1083a4e18e5141ddce7551b79d07d9b272d
-- 
2.35.3


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2023-04-29  5:04 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-04-29  5:04 [pushed] [gdb/build] Fix build without ncurses in maintenance_info_screen Tom de Vries

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).