From: Tom Tromey <tromey@adacore.com>
To: gdb-patches@sourceware.org
Subject: [PATCH 1/5] Fix execute_frame_filters doc string
Date: Wed, 14 Jun 2023 10:30:47 -0600 [thread overview]
Message-ID: <20230614-dap-frame-decor-v1-1-af87db6467b2@adacore.com> (raw)
In-Reply-To: <20230614-dap-frame-decor-v1-0-af87db6467b2@adacore.com>
When reading the doc string for execute_frame_filters, I wasn't sure
if the ranges were inclusive or exclusive. This patch updates the doc
string to reflect my findings, and also fixes an existing typo.
---
gdb/python/lib/gdb/frames.py | 16 +++++++++-------
1 file changed, 9 insertions(+), 7 deletions(-)
diff --git a/gdb/python/lib/gdb/frames.py b/gdb/python/lib/gdb/frames.py
index 5f8119c22a0..52f4191a8e8 100644
--- a/gdb/python/lib/gdb/frames.py
+++ b/gdb/python/lib/gdb/frames.py
@@ -165,18 +165,20 @@ def execute_frame_filters(frame, frame_low, frame_high):
Arguments:
frame: The initial frame.
- frame_low: The low range of the slice. If this is a negative
- integer then it indicates a backward slice (ie bt -4) which
- counts backward from the last frame in the backtrace.
+ frame_low: The low range of the slice, counting from 0. If
+ this is a negative integer then it indicates a backward slice
+ (ie bt -4) which counts backward from the last frame in the
+ backtrace.
- frame_high: The high range of the slice. If this is -1 then
- it indicates all frames until the end of the stack from
- frame_low.
+ frame_high: The high range of the slice, inclusive. If this
+ is -1 then it indicates all frames until the end of the stack
+ from frame_low.
Returns:
frame_iterator: The sliced iterator after all frame
- filters have had a change to execute, or None if no frame
+ filters have had a chance to execute, or None if no frame
filters are registered.
+
"""
# Get a sorted list of frame filters.
--
2.40.1
next prev parent reply other threads:[~2023-06-14 16:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-14 16:30 [PATCH 0/5] Reimplement DAP backtrace using frame filters Tom Tromey
2023-06-14 16:30 ` Tom Tromey [this message]
2023-06-14 16:30 ` [PATCH 2/5] Add new interface to frame filter iteration Tom Tromey
2023-06-14 16:30 ` [PATCH 3/5] Fix oversights in frame decorator code Tom Tromey
2023-06-14 16:30 ` [PATCH 4/5] Simplify FrameVars Tom Tromey
2023-06-22 16:09 ` Tom Tromey
2023-06-14 16:30 ` [PATCH 5/5] Reimplement DAP stack traces using frame filters Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230614-dap-frame-decor-v1-1-af87db6467b2@adacore.com \
--to=tromey@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).