public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Tom Tromey <tromey@adacore.com>
To: Tom Tromey via Gdb-patches <gdb-patches@sourceware.org>
Cc: Tom Tromey <tromey@adacore.com>
Subject: Re: [PATCH 4/5] Simplify FrameVars
Date: Thu, 22 Jun 2023 10:09:18 -0600	[thread overview]
Message-ID: <87legb1ntd.fsf@tromey.com> (raw)
In-Reply-To: <20230614-dap-frame-decor-v1-4-af87db6467b2@adacore.com> (Tom Tromey via Gdb-patches's message of "Wed, 14 Jun 2023 10:30:50 -0600")

>>>>> "Tom" == Tom Tromey via Gdb-patches <gdb-patches@sourceware.org> writes:

Tom> FrameVars implements its own variant of Symbol.is_variable and/or
Tom> Symbol.is_control.  This patch replaces this code.

Tom> -                if self.fetch_b(sym):
Tom> +                if sym.is_variable or sym.is_constant:

I found out that using is_constant here is wrong, as this picks up local
enum constants, which aren't really interesting as variables.

In v2 of the series I fix this, and I tack on a test case at the end of
the series.

Tom

  reply	other threads:[~2023-06-22 16:09 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-14 16:30 [PATCH 0/5] Reimplement DAP backtrace using frame filters Tom Tromey
2023-06-14 16:30 ` [PATCH 1/5] Fix execute_frame_filters doc string Tom Tromey
2023-06-14 16:30 ` [PATCH 2/5] Add new interface to frame filter iteration Tom Tromey
2023-06-14 16:30 ` [PATCH 3/5] Fix oversights in frame decorator code Tom Tromey
2023-06-14 16:30 ` [PATCH 4/5] Simplify FrameVars Tom Tromey
2023-06-22 16:09   ` Tom Tromey [this message]
2023-06-14 16:30 ` [PATCH 5/5] Reimplement DAP stack traces using frame filters Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87legb1ntd.fsf@tromey.com \
    --to=tromey@adacore.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).