public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Tom Tromey <tromey@adacore.com>
To: gdb-patches@sourceware.org
Subject: [PATCH 0/6] Several DAP fixes for VSCode
Date: Tue, 25 Jul 2023 07:49:37 -0600	[thread overview]
Message-ID: <20230725-dap-bt-path-v1-0-bb015b0d8e54@adacore.com> (raw)

Vladimir Makaev tried the gdb DAP implementation with VSCode and found
a few bugs.  This series fixes these.  It also adds a new DAP launch
parameter -- I thought I was going to need this, and while I didn't,
it still seemed like a good idea to add.

I'm not completely happy with this series.  See the "full paths" patch
for some discussion.  Essentially I think the FrameDecorator API is
not very well thought out, and once again this is an area where it
would be very nice if we could add new methods to the spec.

I wonder whether we should.  One difference between pretty-printers
and frame decorators is that my sense is that there are many more of
the former, so the smaller for the latter.

Another idea I had for that patch is to just change the base behavior
of FrameDecorator, based on a global flag -- that would only be set by
DAP.

---
Tom Tromey (6):
      Rename private member of FrameDecorator
      Refactor dap_launch
      Add "cwd" parameter to DAP launch request
      Full paths in DAP stackTrace responses
      Move DAP breakpoint event code to breakpoint.py
      Do not send "new breakpoint" event when breakpoint is set

 gdb/doc/gdb.texinfo                    |   8 +++
 gdb/python/lib/gdb/FrameDecorator.py   | 119 ++++++++++++++++++++-------------
 gdb/python/lib/gdb/dap/breakpoint.py   |  64 +++++++++++++++++-
 gdb/python/lib/gdb/dap/events.py       |  37 ----------
 gdb/python/lib/gdb/dap/launch.py       |  34 +++++-----
 gdb/python/lib/gdb/frames.py           |  14 +++-
 gdb/testsuite/gdb.dap/args-env.exp     |   2 +-
 gdb/testsuite/gdb.dap/basic-dap.exp    |  11 +--
 gdb/testsuite/gdb.dap/cwd.exp          |  40 +++++++++++
 gdb/testsuite/gdb.dap/stop-at-main.exp |   2 +-
 gdb/testsuite/lib/dap-support.exp      |  72 +++++++++++++-------
 11 files changed, 262 insertions(+), 141 deletions(-)
---
base-commit: 695776dc2f43c56dd2ae2f7036fb7cf74e19b46b
change-id: 20230725-dap-bt-path-32e910a3ee36

Best regards,
-- 
Tom Tromey <tromey@adacore.com>


             reply	other threads:[~2023-07-25 13:49 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-25 13:49 Tom Tromey [this message]
2023-07-25 13:49 ` [PATCH 1/6] Rename private member of FrameDecorator Tom Tromey
2023-07-28 14:50   ` Lancelot SIX
2023-07-31 14:30     ` Tom Tromey
2023-07-31 14:36       ` Lancelot SIX
2023-07-25 13:49 ` [PATCH 2/6] Refactor dap_launch Tom Tromey
2023-07-25 13:49 ` [PATCH 3/6] Add "cwd" parameter to DAP launch request Tom Tromey
2023-07-25 14:07   ` Eli Zaretskii
2023-07-25 13:49 ` [PATCH 4/6] Full paths in DAP stackTrace responses Tom Tromey
2023-07-28 15:29   ` Lancelot SIX
2023-07-31 16:26     ` Tom Tromey
2023-07-25 13:49 ` [PATCH 5/6] Move DAP breakpoint event code to breakpoint.py Tom Tromey
2023-07-25 13:49 ` [PATCH 6/6] Do not send "new breakpoint" event when breakpoint is set Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230725-dap-bt-path-v1-0-bb015b0d8e54@adacore.com \
    --to=tromey@adacore.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).