From: Tom Tromey <tromey@adacore.com>
To: Lancelot SIX <lsix@lancelotsix.com>
Cc: Tom Tromey <tromey@adacore.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH 4/6] Full paths in DAP stackTrace responses
Date: Mon, 31 Jul 2023 10:26:57 -0600 [thread overview]
Message-ID: <878rawgi7i.fsf@tromey.com> (raw)
In-Reply-To: <20230728151539.qnrgzb37fub34tke@octopus> (Lancelot SIX's message of "Fri, 28 Jul 2023 16:29:08 +0100")
>> +class FrameDecorator(_FrameDecoratorBase):
>> + """Basic implementation of a Frame Decorator"""
>> +
Lancelot> I can see that this pre-existed your patch, but is it expected to have
Lancelot> two docstrings instead of one with empty lines to separate paragraphs?
Nope, I've fixed it.
>> @@ -172,7 +172,11 @@ def _frame_iterator(frame, frame_low, frame_high, always):
>>
>> # Apply a basic frame decorator to all gdb.Frames. This unifies
>> # the interface.
>> - frame_iterator = map(FrameDecorator, frame_iterator)
>> + if always:
>> + decorator = DAPFrameDecorator
>> + else:
>> + decorator = FrameDecorator
>> + frame_iterator = map(decorator, frame_iterator)
Lancelot> The purpose of always (always return an iterator) seems orthogonal to
Lancelot> the way `filename()` behaves. I find this confusing. Should the
Lancelot> parameter be renamed / a new parameter added?
I renamed it to "dap_semantics".
Tom
next prev parent reply other threads:[~2023-07-31 16:27 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-25 13:49 [PATCH 0/6] Several DAP fixes for VSCode Tom Tromey
2023-07-25 13:49 ` [PATCH 1/6] Rename private member of FrameDecorator Tom Tromey
2023-07-28 14:50 ` Lancelot SIX
2023-07-31 14:30 ` Tom Tromey
2023-07-31 14:36 ` Lancelot SIX
2023-07-25 13:49 ` [PATCH 2/6] Refactor dap_launch Tom Tromey
2023-07-25 13:49 ` [PATCH 3/6] Add "cwd" parameter to DAP launch request Tom Tromey
2023-07-25 14:07 ` Eli Zaretskii
2023-07-25 13:49 ` [PATCH 4/6] Full paths in DAP stackTrace responses Tom Tromey
2023-07-28 15:29 ` Lancelot SIX
2023-07-31 16:26 ` Tom Tromey [this message]
2023-07-25 13:49 ` [PATCH 5/6] Move DAP breakpoint event code to breakpoint.py Tom Tromey
2023-07-25 13:49 ` [PATCH 6/6] Do not send "new breakpoint" event when breakpoint is set Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878rawgi7i.fsf@tromey.com \
--to=tromey@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=lsix@lancelotsix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).