From: Eli Zaretskii <eliz@gnu.org>
To: Tom Tromey <tromey@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 3/6] Add "cwd" parameter to DAP launch request
Date: Tue, 25 Jul 2023 17:07:48 +0300 [thread overview]
Message-ID: <83ila8ozij.fsf@gnu.org> (raw)
In-Reply-To: <20230725-dap-bt-path-v1-3-bb015b0d8e54@adacore.com> (message from Tom Tromey via Gdb-patches on Tue, 25 Jul 2023 07:49:40 -0600)
> Date: Tue, 25 Jul 2023 07:49:40 -0600
> From: Tom Tromey via Gdb-patches <gdb-patches@sourceware.org>
>
> This adds the "cwd" parameter to the DAP launch request.
>
> This came up here:
> https://github.com/eclipse-cdt-cloud/cdt-gdb-adapter/issues/90
> ... and seemed like a good idea.
> ---
> gdb/doc/gdb.texinfo | 8 ++++++++
> gdb/python/lib/gdb/dap/launch.py | 34 ++++++++++++++++-----------------
> gdb/testsuite/gdb.dap/cwd.exp | 40 +++++++++++++++++++++++++++++++++++++++
> gdb/testsuite/lib/dap-support.exp | 5 +++++
> 4 files changed, 70 insertions(+), 17 deletions(-)
OK for the documentation part, thanks.
Reviewed-By: Eli Zaretskii <eliz@gnu.org>
next prev parent reply other threads:[~2023-07-25 14:07 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-25 13:49 [PATCH 0/6] Several DAP fixes for VSCode Tom Tromey
2023-07-25 13:49 ` [PATCH 1/6] Rename private member of FrameDecorator Tom Tromey
2023-07-28 14:50 ` Lancelot SIX
2023-07-31 14:30 ` Tom Tromey
2023-07-31 14:36 ` Lancelot SIX
2023-07-25 13:49 ` [PATCH 2/6] Refactor dap_launch Tom Tromey
2023-07-25 13:49 ` [PATCH 3/6] Add "cwd" parameter to DAP launch request Tom Tromey
2023-07-25 14:07 ` Eli Zaretskii [this message]
2023-07-25 13:49 ` [PATCH 4/6] Full paths in DAP stackTrace responses Tom Tromey
2023-07-28 15:29 ` Lancelot SIX
2023-07-31 16:26 ` Tom Tromey
2023-07-25 13:49 ` [PATCH 5/6] Move DAP breakpoint event code to breakpoint.py Tom Tromey
2023-07-25 13:49 ` [PATCH 6/6] Do not send "new breakpoint" event when breakpoint is set Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83ila8ozij.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=tromey@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).