From: Tom de Vries <tdevries@suse.de>
To: gdb-patches@sourceware.org
Subject: [PATCH] [gdb/build] Fix YYSTYPE and yyalloc odr violation
Date: Mon, 14 Aug 2023 14:24:41 +0200 [thread overview]
Message-ID: <20230814122441.20617-1-tdevries@suse.de> (raw)
When building gdb with -O2 -flto I run into:
...
ada-exp.c.tmp:576:7: error: type ‘union YYSTYPE’ violates the C++ One \
Definition Rule [-Werror=odr]
...
Fix this by renaming to ada_YYSTYPE and likewise for other .y files.
Likewise for yyalloc.
Tested on x86_64-linux.
PR build/22395
Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=22395
---
gdb/Makefile.in | 2 ++
1 file changed, 2 insertions(+)
diff --git a/gdb/Makefile.in b/gdb/Makefile.in
index 8521e8d11c8..ccdd84beea6 100644
--- a/gdb/Makefile.in
+++ b/gdb/Makefile.in
@@ -2509,6 +2509,8 @@ po/$(PACKAGE).pot: force
-e 's/\([ \t;,(]\)free$$/\1xfree/g' \
-e '/^#line.*y.tab.c/d' \
-e 's/YY_NULL/YY_NULLPTR/g' \
+ -e "s/YYSTYPE/$(subst -,_,$*)_YYSTYPE/g" \
+ -e "s/yyalloc/$(subst -,_,$*)_yyalloc/g" \
< $@.tmp > $@.new && \
rm -f $@.tmp && \
mv $@.new $@
base-commit: 7a379ae2383034ad79a0c46b87a08ff1facd25c3
--
2.35.3
next reply other threads:[~2023-08-14 12:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-14 12:24 Tom de Vries [this message]
2023-08-14 16:10 ` Tom Tromey
2023-08-14 20:54 ` Tom de Vries
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230814122441.20617-1-tdevries@suse.de \
--to=tdevries@suse.de \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).