public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Tom de Vries <tdevries@suse.de>
To: Tom Tromey <tom@tromey.com>,
	Tom de Vries via Gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH] [gdb/build] Fix YYSTYPE and yyalloc odr violation
Date: Mon, 14 Aug 2023 22:54:38 +0200	[thread overview]
Message-ID: <be6be36f-af95-c508-8363-90381a8ecbac@suse.de> (raw)
In-Reply-To: <87edk5zjtv.fsf@tromey.com>

On 8/14/23 18:10, Tom Tromey wrote:
>>>>>> "Tom" == Tom de Vries via Gdb-patches <gdb-patches@sourceware.org> writes:
> 
> Tom> When building gdb with -O2 -flto I run into:
> Tom> ...
> Tom> ada-exp.c.tmp:576:7: error: type ‘union YYSTYPE’ violates the C++ One \
> Tom>   Definition Rule [-Werror=odr]
> Tom> ...
> 
> Tom> Fix this by renaming to ada_YYSTYPE and likewise for other .y files.
> 
> Tom> Likewise for yyalloc.
> 
> It is fine by me but did you try it with byacc?

Thanks for the review.

I hadn't, but have now, and ran into this PR ( 
https://sourceware.org/bugzilla/show_bug.cgi?id=30760 ), reproduces with 
and without this patch.

Committed.

Thanks,
- Tom

> Approved-By: Tom Tromey <tom@tromey.com>
> 
> Tom


      reply	other threads:[~2023-08-14 20:54 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-14 12:24 Tom de Vries
2023-08-14 16:10 ` Tom Tromey
2023-08-14 20:54   ` Tom de Vries [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=be6be36f-af95-c508-8363-90381a8ecbac@suse.de \
    --to=tdevries@suse.de \
    --cc=gdb-patches@sourceware.org \
    --cc=tom@tromey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).