From: Tom Tromey <tromey@adacore.com>
To: gdb-patches@sourceware.org
Subject: [PATCH 3/4] Remove variable_default_display
Date: Fri, 01 Sep 2023 08:47:13 -0600 [thread overview]
Message-ID: <20230901-varobj-fixes-v1-3-b9a1f8139ca7@adacore.com> (raw)
In-Reply-To: <20230901-varobj-fixes-v1-0-b9a1f8139ca7@adacore.com>
variable_default_display has a single caller now, so remove it.
---
gdb/varobj.c | 12 +-----------
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/gdb/varobj.c b/gdb/varobj.c
index 760809c6f51..3ae8d728e82 100644
--- a/gdb/varobj.c
+++ b/gdb/varobj.c
@@ -164,8 +164,6 @@ create_child_with_value (struct varobj *parent, int index,
/* Utility routines */
-static enum varobj_display_formats variable_default_display (struct varobj *);
-
static bool update_type_if_necessary (struct varobj *var,
struct value *new_value);
@@ -336,7 +334,7 @@ varobj_create (const char *objname,
return NULL;
}
- var->format = variable_default_display (var.get ());
+ var->format = FORMAT_NATURAL;
var->root->valid_block =
var->root->floating ? NULL : tracker.block ();
var->root->global
@@ -1871,14 +1869,6 @@ varobj_get_value_type (const struct varobj *var)
return type;
}
-/* What is the default display for this variable? We assume that
- everything is "natural". Any exceptions? */
-static enum varobj_display_formats
-variable_default_display (struct varobj *var)
-{
- return FORMAT_NATURAL;
-}
-
/*
* Language-dependencies
*/
--
2.40.1
next prev parent reply other threads:[~2023-09-01 14:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-01 14:47 [PATCH 0/4] Fix two varobj bugs Tom Tromey
2023-09-01 14:47 ` [PATCH 1/4] Allow pretty-printer 'children' method to return strings Tom Tromey
2023-09-01 14:47 ` [PATCH 2/4] Remove dead code from varobj_set_display_format Tom Tromey
2023-09-01 14:47 ` Tom Tromey [this message]
2023-09-01 14:47 ` [PATCH 4/4] Fix bug in -var-evaluate-expression Tom Tromey
2023-09-01 17:34 ` [PATCH 0/4] Fix two varobj bugs Keith Seitz
2023-09-07 19:40 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230901-varobj-fixes-v1-3-b9a1f8139ca7@adacore.com \
--to=tromey@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).