From: Keith Seitz <keiths@redhat.com>
To: Tom Tromey <tromey@adacore.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH 0/4] Fix two varobj bugs
Date: Fri, 1 Sep 2023 10:34:04 -0700 [thread overview]
Message-ID: <a683757f-c390-4a99-8ec0-8bde98a10e7d@redhat.com> (raw)
In-Reply-To: <20230901-varobj-fixes-v1-0-b9a1f8139ca7@adacore.com>
On 9/1/23 07:47, Tom Tromey via Gdb-patches wrote:
> This series fixes a couple of small varobj bugs, and includes a couple
> small cleanups as well.
>
> Regression tested on x86-64 Fedora 36.
I've looked over this series, and I don't see any issues.
Reviewed-by: Keith Seitz <keiths@redhat.com>
Keith
> ---
> Tom Tromey (4):
> Allow pretty-printer 'children' method to return strings
> Remove dead code from varobj_set_display_format
> Remove variable_default_display
> Fix bug in -var-evaluate-expression
>
> gdb/testsuite/gdb.python/py-varobj.c | 28 ++++++++++++++++
> gdb/testsuite/gdb.python/py-varobj.exp | 61 ++++++++++++++++++++++++++++++++++
> gdb/testsuite/gdb.python/py-varobj.py | 37 +++++++++++++++++++++
> gdb/varobj.c | 39 ++++++++--------------
> 4 files changed, 140 insertions(+), 25 deletions(-)
> ---
> base-commit: b47a4f92de5c12ac8bdac57b0413e3e05d411832
> change-id: 20230901-varobj-fixes-9926a7876ec6
>
> Best regards,
next prev parent reply other threads:[~2023-09-01 17:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-01 14:47 Tom Tromey
2023-09-01 14:47 ` [PATCH 1/4] Allow pretty-printer 'children' method to return strings Tom Tromey
2023-09-01 14:47 ` [PATCH 2/4] Remove dead code from varobj_set_display_format Tom Tromey
2023-09-01 14:47 ` [PATCH 3/4] Remove variable_default_display Tom Tromey
2023-09-01 14:47 ` [PATCH 4/4] Fix bug in -var-evaluate-expression Tom Tromey
2023-09-01 17:34 ` Keith Seitz [this message]
2023-09-07 19:40 ` [PATCH 0/4] Fix two varobj bugs Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a683757f-c390-4a99-8ec0-8bde98a10e7d@redhat.com \
--to=keiths@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).