public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Simon Marchi <simon.marchi@efficios.com>
To: gdb-patches@sourceware.org
Cc: Simon Marchi <simon.marchi@efficios.com>
Subject: [PATCH v3 2/3] gdb/testsuite: add linux target check in allow_hipcc_tests
Date: Fri, 15 Sep 2023 10:52:12 -0400	[thread overview]
Message-ID: <20230915145249.22318-2-simon.marchi@efficios.com> (raw)
In-Reply-To: <20230915145249.22318-1-simon.marchi@efficios.com>

ROCm / HIP tests should only run on Linux for now, existing gdb.rocm
tests miss such a check.  Add an "istarget linux" check in
allow_hipcc_tests.

Change-Id: I71f69e510a754f2fdadc32de53b923ebb9835ab5
---
 gdb/testsuite/lib/rocm.exp | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/gdb/testsuite/lib/rocm.exp b/gdb/testsuite/lib/rocm.exp
index 98a3b308228d..791f1b403bb7 100644
--- a/gdb/testsuite/lib/rocm.exp
+++ b/gdb/testsuite/lib/rocm.exp
@@ -67,6 +67,10 @@ gdb_caching_proc allow_hipcc_tests {} {
 	return {0 "remote debugging"}
     }
 
+    if {![istarget "*-linux*"]} {
+	return {0 "target platform is not Linux"}
+    }
+
     # Ensure that GDB is built with amd-dbgapi support.
     set output [remote_exec host $::GDB "$::INTERNAL_GDBFLAGS --configuration"]
     if { [string first "--with-amd-dbgapi" $output] == -1 } {
-- 
2.42.0


  reply	other threads:[~2023-09-15 14:52 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-15 14:52 [PATCH v3 1/3] gdb: add inferior_cloned observable Simon Marchi
2023-09-15 14:52 ` Simon Marchi [this message]
2023-09-15 17:19   ` [PATCH v3 2/3] gdb/testsuite: add linux target check in allow_hipcc_tests Lancelot SIX
2023-09-15 20:18     ` Simon Marchi
2023-09-15 14:52 ` [PATCH v3 3/3] gdb/amdgpu: add precise-memory support Simon Marchi
2023-09-15 16:04   ` Lancelot SIX
2023-09-15 16:29     ` Simon Marchi
2023-09-15 17:16       ` Lancelot SIX
2023-09-15 20:19         ` Simon Marchi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230915145249.22318-2-simon.marchi@efficios.com \
    --to=simon.marchi@efficios.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).