Re: [PATCH v3 3/3] gdb/amdgpu: add precise-memory support

[Lancelot SIX <lsix@lancelotsix.com>]

> > Moving the initialization in the ctor's body would solve the issue
> > 
> >   explicit amd_dbgapi_inferior_info (inferior *inf,
> >                                      bool precise_memory_requested = false)
> >     : inf {inf}
> >   {
> >     precise_memory.requested = precise_memory_requested;
> >   }
> > 
> > The alternative would be to name
> > amd_dbgapi_inferior_info::precise_memory's type and give it a ctor.
> 
> In this case I would just do:
> 
> diff --git a/gdb/amd-dbgapi-target.c b/gdb/amd-dbgapi-target.c
> index 507824decf8d..40baf156d83f 100644
> --- a/gdb/amd-dbgapi-target.c
> +++ b/gdb/amd-dbgapi-target.c
> @@ -119,8 +119,10 @@ struct amd_dbgapi_inferior_info
>  {
>    explicit amd_dbgapi_inferior_info (inferior *inf,
>  				     bool precise_memory_requested = false)
> -    : inf {inf}, precise_memory {precise_memory_requested}
> -  {}
> +    : inf (inf)
> +  {
> +    precise_memory.requested = precise_memory_requested;
> +  }

That would work for me.

Lancelot.

> 
>    /* Backlink to inferior.  */
>    inferior *inf;
> 
> ---
> 
> Or, we can just have two separate fields (precise_memory_requested and
> precise_memory_enabled), they don't really need to be in a struct.
> 
> Simon