From: Luis Machado <luis.machado@arm.com>
To: <gdb-patches@sourceware.org>
Cc: <thiago.bauermann@linaro.org>, <simon.marchi@polymtl.ca>
Subject: [PATCH v7 13/18] [gdb/generic] Get rid of linux-core-thread-data
Date: Mon, 18 Sep 2023 22:26:46 +0100 [thread overview]
Message-ID: <20230918212651.660141-14-luis.machado@arm.com> (raw)
In-Reply-To: <20230918212651.660141-1-luis.machado@arm.com>
This struct type seems to have been used in the past as a callback
parameter. Now it seems that case is no longer true, so we can simplify
things by passing the individual parameters linux_core_thread_data
encapsulates directly to the functions.
This is just a cleanup before the next change.
Approved-By: Simon Marchi <simon.marchi@efficios.com>
---
gdb/linux-tdep.c | 49 +++++++++++++++---------------------------------
1 file changed, 15 insertions(+), 34 deletions(-)
diff --git a/gdb/linux-tdep.c b/gdb/linux-tdep.c
index b5eee5e108c..a4a86b01bdb 100644
--- a/gdb/linux-tdep.c
+++ b/gdb/linux-tdep.c
@@ -1820,47 +1820,29 @@ linux_get_siginfo_data (thread_info *thread, struct gdbarch *gdbarch)
return buf;
}
-struct linux_corefile_thread_data
-{
- linux_corefile_thread_data (struct gdbarch *gdbarch, bfd *obfd,
- gdb::unique_xmalloc_ptr<char> ¬e_data,
- int *note_size, gdb_signal stop_signal)
- : gdbarch (gdbarch), obfd (obfd), note_data (note_data),
- note_size (note_size), stop_signal (stop_signal)
- {}
-
- struct gdbarch *gdbarch;
- bfd *obfd;
- gdb::unique_xmalloc_ptr<char> ¬e_data;
- int *note_size;
- enum gdb_signal stop_signal;
-};
-
/* Records the thread's register state for the corefile note
section. */
static void
linux_corefile_thread (struct thread_info *info,
- struct linux_corefile_thread_data *args)
+ struct gdbarch *gdbarch, bfd *obfd,
+ gdb::unique_xmalloc_ptr<char> ¬e_data,
+ int *note_size, gdb_signal stop_signal)
{
- gcore_elf_build_thread_register_notes (args->gdbarch, info,
- args->stop_signal,
- args->obfd, &args->note_data,
- args->note_size);
+ gcore_elf_build_thread_register_notes (gdbarch, info, stop_signal, obfd,
+ ¬e_data, note_size);
/* Don't return anything if we got no register information above,
such a core file is useless. */
- if (args->note_data != NULL)
+ if (note_data != nullptr)
{
gdb::byte_vector siginfo_data
- = linux_get_siginfo_data (info, args->gdbarch);
+ = linux_get_siginfo_data (info, gdbarch);
if (!siginfo_data.empty ())
- args->note_data.reset (elfcore_write_note (args->obfd,
- args->note_data.release (),
- args->note_size,
- "CORE", NT_SIGINFO,
- siginfo_data.data (),
- siginfo_data.size ()));
+ note_data.reset (elfcore_write_note (obfd, note_data.release (),
+ note_size, "CORE", NT_SIGINFO,
+ siginfo_data.data (),
+ siginfo_data.size ()));
}
}
@@ -2095,17 +2077,16 @@ linux_make_corefile_notes (struct gdbarch *gdbarch, bfd *obfd, int *note_size)
else
stop_signal = GDB_SIGNAL_0;
- linux_corefile_thread_data thread_args (gdbarch, obfd, note_data, note_size,
- stop_signal);
-
if (signalled_thr != nullptr)
- linux_corefile_thread (signalled_thr, &thread_args);
+ linux_corefile_thread (signalled_thr, gdbarch, obfd, note_data, note_size,
+ stop_signal);
for (thread_info *thr : current_inferior ()->non_exited_threads ())
{
if (thr == signalled_thr)
continue;
- linux_corefile_thread (thr, &thread_args);
+ linux_corefile_thread (thr, gdbarch, obfd, note_data, note_size,
+ stop_signal);
}
if (!note_data)
--
2.25.1
next prev parent reply other threads:[~2023-09-18 21:27 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-18 21:26 [PATCH v7 00/18] SME support for AArch64 gdb/gdbserver on Linux Luis Machado
2023-09-18 21:26 ` [PATCH v7 01/18] [gdb/aarch64] Fix register fetch/store order for native AArch64 Linux Luis Machado
2023-09-18 21:26 ` [PATCH v7 02/18] [gdb/aarch64] refactor: Rename SVE-specific files Luis Machado
2023-09-18 21:26 ` [PATCH v7 03/18] [gdb/gdbserver] refactor: Simplify SVE interface to read/write registers Luis Machado
2023-09-18 21:26 ` [PATCH v7 04/18] [gdb/aarch64] sve: Fix return command when using V registers in a SVE-enabled target Luis Machado
2023-09-18 21:26 ` [PATCH v7 05/18] [gdb/aarch64] sme: Enable SME registers and pseudo-registers Luis Machado
2023-10-13 13:06 ` Tom Tromey
2023-10-13 14:44 ` Luis Machado
2023-10-13 14:50 ` Luis Machado
2023-09-18 21:26 ` [PATCH v7 06/18] [gdbserver/generic] Convert tdesc's expedite_regs to a string vector Luis Machado
2023-09-18 21:26 ` [PATCH v7 07/18] [gdbserver/aarch64] refactor: Adjust expedited registers dynamically Luis Machado
2023-09-18 21:26 ` [PATCH v7 08/18] [gdbserver/aarch64] sme: Add support for SME Luis Machado
2023-09-18 21:26 ` [PATCH v7 09/18] [gdb/aarch64] sve: Fix signal frame z/v register restore Luis Machado
2023-09-18 21:26 ` [PATCH v7 10/18] [gdb/aarch64] sme: Signal frame support Luis Machado
2023-09-18 21:26 ` [PATCH v7 11/18] [gdb/aarch64] sme: Fixup sigframe gdbarch when vg/svg changes Luis Machado
2023-09-18 21:26 ` [PATCH v7 12/18] [gdb/aarch64] sme: Support TPIDR2 signal frame context Luis Machado
2023-09-18 21:26 ` Luis Machado [this message]
2023-09-18 21:26 ` [PATCH v7 14/18] [gdb/generic] corefile/bug: Use thread-specific gdbarch when dumping register state to core files Luis Machado
2023-09-18 21:26 ` [PATCH v7 15/18] [gdb/generic] corefile/bug: Add hook to control the use of target description notes from corefiles Luis Machado
2023-09-19 20:49 ` Simon Marchi
2023-09-20 5:49 ` Luis Machado
2023-09-20 14:01 ` Luis Machado
2023-09-20 14:22 ` Andrew Burgess
2023-09-20 15:26 ` Andrew Burgess
2023-09-20 23:35 ` Luis Machado
2023-09-21 10:02 ` Andrew Burgess
2023-09-21 10:44 ` Luis Machado
2023-09-25 9:57 ` Andrew Burgess
2023-09-26 12:39 ` Luis Machado
2023-09-27 17:56 ` Andrew Burgess
2023-09-28 8:23 ` Luis Machado
2023-10-03 17:23 ` Andrew Burgess
2023-10-04 15:27 ` Luis Machado
2023-09-25 15:41 ` Simon Marchi
2023-09-27 17:44 ` Andrew Burgess
2023-09-18 21:26 ` [PATCH v7 16/18] [gdb/aarch64] sme: Core file support for Linux Luis Machado
2023-09-18 21:26 ` [PATCH v7 17/18] [gdb/testsuite] sme: Add SVE/SME testcases Luis Machado
2023-09-19 19:12 ` Simon Marchi
2023-09-19 20:02 ` Luis Machado
2023-09-18 21:26 ` [PATCH v7 18/18] [gdb/docs] sme: Document SME registers and features Luis Machado
2023-10-04 15:27 ` [PATCH v7 00/18] SME support for AArch64 gdb/gdbserver on Linux Luis Machado
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230918212651.660141-14-luis.machado@arm.com \
--to=luis.machado@arm.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@polymtl.ca \
--cc=thiago.bauermann@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).