From: Luis Machado <luis.machado@arm.com>
To: Tom Tromey <tromey@adacore.com>,
Luis Machado via Gdb-patches <gdb-patches@sourceware.org>
Cc: thiago.bauermann@linaro.org
Subject: Re: [PATCH v7 05/18] [gdb/aarch64] sme: Enable SME registers and pseudo-registers
Date: Fri, 13 Oct 2023 15:50:09 +0100 [thread overview]
Message-ID: <d63d1eb4-3ea1-4c00-bd83-9b49a14d326f@arm.com> (raw)
In-Reply-To: <d2f257a3-e3a5-4a81-9b07-62cee9aa63cd@arm.com>
On 10/13/23 15:44, Luis Machado wrote:
> On 10/13/23 14:06, Tom Tromey wrote:
>>>>>>> "Luis" == Luis Machado via Gdb-patches <gdb-patches@sourceware.org> writes:
>>
>> Hi Luis.
>>
>> This patch caused a gdbserver build failure on aarch64-linux.
>>
>> In file included from ../../src/gdbserver/../gdb/nat/aarch64-scalable-linux-ptrace.h:36,
>> from ../../src/gdbserver/linux-aarch64-low.cc:48:
>> ../../src/gdbserver/linux-aarch64-low.cc: In function 'void aarch64_adjust_register_sets(const aarch64_features&)':
>> ../../src/gdbserver/../gdb/nat/aarch64-scalable-linux-sigcontext.h:304:45: error: '__SVE_VQ_BYTES' was not declared in this scope; did you mean 'SVE_VQ_BYTES'?
>> 304 | ((sizeof (struct user_za_header) + (__SVE_VQ_BYTES - 1)) \
>> | ^~~~~~~~~~~~~~
>> ../../src/gdbserver/../gdb/nat/aarch64-scalable-linux-sigcontext.h:325:10: note: in expansion of macro 'ZA_PT_ZA_OFFSET'
>> 325 | (ZA_PT_ZA_OFFSET + ZA_PT_ZA_SIZE(vq))
>> | ^~~~~~~~~~~~~~~
>> ../../src/gdbserver/linux-aarch64-low.cc:941:28: note: in expansion of macro 'ZA_PT_SIZE'
>> 941 | regset->size = ZA_PT_SIZE (features.svq);
>> | ^~~~~~~~~~
>> CXX nat/aarch64-linux.o
>>
>> Luis> +/* Make sure we only define these if the kernel header doesn't. */
>> Luis> +#ifndef ZA_PT_SIZE
>> ...
>> Luis> +/* Offset from the start of struct user_za_header to the register data */
>> Luis> +#define ZA_PT_ZA_OFFSET \
>> Luis> + ((sizeof (struct user_za_header) + (__SVE_VQ_BYTES - 1)) \
>> Luis> + / __SVE_VQ_BYTES * __SVE_VQ_BYTES)
>>
>> Is it safe to just remove the "__" as the compiler suggests?
>>
>> thanks,
>> Tom
>
> Should be, if it is defined. Let me look into it.
We should use SVE_VQ_BYTES as opposed to __SVE_VQ_BYTES here. __SVE_VQ_BYTES is only available if the
system headers include that definition, which older distros may not include.
Does it build fine with that? If so, I can push that change, but I want to make sure the path of
building aarch64 gdbserver on a system without SVE headers works. My testing systems are probably
newer and have that definition available.
next prev parent reply other threads:[~2023-10-13 14:50 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-18 21:26 [PATCH v7 00/18] SME support for AArch64 gdb/gdbserver on Linux Luis Machado
2023-09-18 21:26 ` [PATCH v7 01/18] [gdb/aarch64] Fix register fetch/store order for native AArch64 Linux Luis Machado
2023-09-18 21:26 ` [PATCH v7 02/18] [gdb/aarch64] refactor: Rename SVE-specific files Luis Machado
2023-09-18 21:26 ` [PATCH v7 03/18] [gdb/gdbserver] refactor: Simplify SVE interface to read/write registers Luis Machado
2023-09-18 21:26 ` [PATCH v7 04/18] [gdb/aarch64] sve: Fix return command when using V registers in a SVE-enabled target Luis Machado
2023-09-18 21:26 ` [PATCH v7 05/18] [gdb/aarch64] sme: Enable SME registers and pseudo-registers Luis Machado
2023-10-13 13:06 ` Tom Tromey
2023-10-13 14:44 ` Luis Machado
2023-10-13 14:50 ` Luis Machado [this message]
2023-09-18 21:26 ` [PATCH v7 06/18] [gdbserver/generic] Convert tdesc's expedite_regs to a string vector Luis Machado
2023-09-18 21:26 ` [PATCH v7 07/18] [gdbserver/aarch64] refactor: Adjust expedited registers dynamically Luis Machado
2023-09-18 21:26 ` [PATCH v7 08/18] [gdbserver/aarch64] sme: Add support for SME Luis Machado
2023-09-18 21:26 ` [PATCH v7 09/18] [gdb/aarch64] sve: Fix signal frame z/v register restore Luis Machado
2023-09-18 21:26 ` [PATCH v7 10/18] [gdb/aarch64] sme: Signal frame support Luis Machado
2023-09-18 21:26 ` [PATCH v7 11/18] [gdb/aarch64] sme: Fixup sigframe gdbarch when vg/svg changes Luis Machado
2023-09-18 21:26 ` [PATCH v7 12/18] [gdb/aarch64] sme: Support TPIDR2 signal frame context Luis Machado
2023-09-18 21:26 ` [PATCH v7 13/18] [gdb/generic] Get rid of linux-core-thread-data Luis Machado
2023-09-18 21:26 ` [PATCH v7 14/18] [gdb/generic] corefile/bug: Use thread-specific gdbarch when dumping register state to core files Luis Machado
2023-09-18 21:26 ` [PATCH v7 15/18] [gdb/generic] corefile/bug: Add hook to control the use of target description notes from corefiles Luis Machado
2023-09-19 20:49 ` Simon Marchi
2023-09-20 5:49 ` Luis Machado
2023-09-20 14:01 ` Luis Machado
2023-09-20 14:22 ` Andrew Burgess
2023-09-20 15:26 ` Andrew Burgess
2023-09-20 23:35 ` Luis Machado
2023-09-21 10:02 ` Andrew Burgess
2023-09-21 10:44 ` Luis Machado
2023-09-25 9:57 ` Andrew Burgess
2023-09-26 12:39 ` Luis Machado
2023-09-27 17:56 ` Andrew Burgess
2023-09-28 8:23 ` Luis Machado
2023-10-03 17:23 ` Andrew Burgess
2023-10-04 15:27 ` Luis Machado
2023-09-25 15:41 ` Simon Marchi
2023-09-27 17:44 ` Andrew Burgess
2023-09-18 21:26 ` [PATCH v7 16/18] [gdb/aarch64] sme: Core file support for Linux Luis Machado
2023-09-18 21:26 ` [PATCH v7 17/18] [gdb/testsuite] sme: Add SVE/SME testcases Luis Machado
2023-09-19 19:12 ` Simon Marchi
2023-09-19 20:02 ` Luis Machado
2023-09-18 21:26 ` [PATCH v7 18/18] [gdb/docs] sme: Document SME registers and features Luis Machado
2023-10-04 15:27 ` [PATCH v7 00/18] SME support for AArch64 gdb/gdbserver on Linux Luis Machado
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d63d1eb4-3ea1-4c00-bd83-9b49a14d326f@arm.com \
--to=luis.machado@arm.com \
--cc=gdb-patches@sourceware.org \
--cc=thiago.bauermann@linaro.org \
--cc=tromey@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).