From: Kevin Buettner <kevinb@redhat.com>
To: "Arsen Arsenović via Binutils" <binutils@sourceware.org>
Cc: "Arsen Arsenović" <arsen@aarsen.me>,
gdb-patches@sourceware.org, "Bruno Haible" <bruno@clisp.org>,
"Iain Sandoe" <iain@sandoe.co.uk>
Subject: Re: [PATCH v2 1/2] *: add modern gettext support
Date: Mon, 25 Sep 2023 19:12:56 -0700 [thread overview]
Message-ID: <20230925191256.2b11bf4a@f37-zws-nv> (raw)
In-Reply-To: <20230926004300.1716711-3-arsen@aarsen.me>
On Tue, 26 Sep 2023 02:17:33 +0200
Arsen Arsenović via Binutils <binutils@sourceware.org> wrote:
> gdb/acinclude.m4 | 3 +-
> gdbsupport/Makefile.am | 5 +
[...]
> diff --git a/gdb/acinclude.m4 b/gdb/acinclude.m4
> index 173e40b440a..d505fbbb267 100644
> --- a/gdb/acinclude.m4
> +++ b/gdb/acinclude.m4
> @@ -235,7 +235,8 @@ AC_DEFUN([GDB_AC_CHECK_BFD], [
> # always want our bfd.
> CFLAGS="-I${srcdir}/../include -I../bfd -I${srcdir}/../bfd $CFLAGS"
> LDFLAGS="-L../bfd -L../libiberty $LDFLAGS"
> - intl=`echo $LIBINTL | sed 's,${top_builddir}/,,g'`
> + # LTLIBINTL because we use libtool as CC below.
> + intl="$(echo "$LTLIBINTL" | sed 's,\$[[{(]top_builddir[)}]]/,,')"
> LIBS="-lbfd -liberty $intl $LIBS"
> CC="./libtool --quiet --mode=link $CC"
> AC_CACHE_CHECK(
> diff --git a/gdbsupport/Makefile.am b/gdbsupport/Makefile.am
> index 00524e9a566..f1a641308fe 100644
> --- a/gdbsupport/Makefile.am
> +++ b/gdbsupport/Makefile.am
> @@ -20,6 +20,11 @@
> AUTOMAKE_OPTIONS = no-dist foreign
> ACLOCAL_AMFLAGS = -I . -I ../config
>
> +# Suppress 'configure.ac: error: AM_GNU_GETTEXT used but SUBDIRS not defined'
> +# from Automake, as gdbsupport uses AM_GNU_GETTEXT through
> +# ZW_GNU_GETTEXT_SISTER_DIR, but doesn't have any translations (currently).
> +SUBDIRS =
> +
> AM_CPPFLAGS = -I$(srcdir)/../include -I$(srcdir)/../gdb \
> -I../gnulib/import -I$(srcdir)/../gnulib/import \
> -I.. -I$(srcdir)/.. $(INCINTL) -I../bfd -I$(srcdir)/../bfd \
The GDB portions look reasonable to me, so those parts are approved. You'll
still need to get approval for all of the other areas though.
Approved-by: Kevin Buettner <kevinb@redhat.com> (GDB portions only.)
next prev parent reply other threads:[~2023-09-26 2:13 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-26 0:17 [PATCH v2 0/2] Replace intl/ with out-of-tree GNU gettext Arsen Arsenović
2023-09-26 0:17 ` [PATCH v2 1/2] *: add modern gettext support Arsen Arsenović
2023-09-26 2:12 ` Kevin Buettner [this message]
2023-09-26 7:03 ` Jan Beulich
2023-09-26 7:54 ` Iain Sandoe
2023-09-26 14:44 ` Arsen Arsenović
2023-09-27 7:11 ` Jan Beulich
2023-09-27 13:06 ` Arsen Arsenović
2023-09-27 15:19 ` Nick Clifton
2023-09-27 17:43 ` Arsen Arsenović
2023-09-28 9:43 ` Nick Clifton
2023-09-29 15:58 ` Bruno Haible
2023-09-29 16:27 ` Arsen Arsenović
2023-11-20 16:42 ` Kévin Le Gouguec
2023-11-20 20:30 ` Arsen Arsenović
2023-11-20 21:28 ` Bruno Haible
2023-09-26 0:17 ` [PATCH v2 2/2] *: suppress xgettext 0.22 charset name error Arsen Arsenović
2023-09-27 15:21 ` Nick Clifton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230925191256.2b11bf4a@f37-zws-nv \
--to=kevinb@redhat.com \
--cc=arsen@aarsen.me \
--cc=binutils@sourceware.org \
--cc=bruno@clisp.org \
--cc=gdb-patches@sourceware.org \
--cc=iain@sandoe.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).