From: "Kévin Le Gouguec" <legouguec@adacore.com>
To: "Arsen Arsenović" <arsen@aarsen.me>
Cc: gdb-patches@sourceware.org, binutils@sourceware.org,
Bruno Haible <bruno@clisp.org>, Iain Sandoe <iain@sandoe.co.uk>
Subject: Re: [PATCH v2 1/2] *: add modern gettext support
Date: Mon, 20 Nov 2023 17:42:38 +0100 [thread overview]
Message-ID: <874jhg2x6p.fsf@adacore.com> (raw)
In-Reply-To: <20230926004300.1716711-3-arsen@aarsen.me> ("Arsen =?utf-8?Q?Arsenovi=C4=87=22's?= message of "Tue, 26 Sep 2023 02:17:33 +0200")
Hello!
Do I understand correctly that this patch, committed as
2023-11-15 "Finalized intl-update patches" (862776f26a5)
specifically the bits quoted below, remove the support for in-tree
libiconv introduced in
2015-08-24 "Missing parts of fixes for in-tree libiconv" (cfe101c6a82)
? If so, was this intentional?
Arsen Arsenović <arsen@aarsen.me> writes:
> […]
> config/ChangeLog:
>
> * intlmacosx.m4: Import from gettext-0.22 (serial 8).
> * gettext.m4: Sync with gettext-0.22 (serial 77).
> * gettext-sister.m4 (ZW_GNU_GETTEXT_SISTER_DIR): Load gettext's
> uninstalled-config.sh, or call AM_GNU_GETTEXT if missing.
> * iconv.m4: Sync with gettext-0.22 (serial 26).
> […]
> diff --git a/config/iconv.m4 b/config/iconv.m4
> index f1e54c5aedc..ff5d5261139 100644
> --- a/config/iconv.m4
> +++ b/config/iconv.m4
> […]
> - CPPFLAGS="$am_save_CPPFLAGS"
> -
> - if test "$am_cv_func_iconv" != yes && test -d ../libiconv; then
> - for _libs in .libs _libs; do
> - am_save_CPPFLAGS="$CPPFLAGS"
> - am_save_LIBS="$LIBS"
> - CPPFLAGS="$CPPFLAGS -I../libiconv/include"
> - LIBS="$LIBS ../libiconv/lib/$_libs/libiconv.a"
> - AC_TRY_LINK([#include <stdlib.h>
> -#include <iconv.h>],
> - [iconv_t cd = iconv_open("","");
> + AC_LINK_IFELSE(
> + [AC_LANG_PROGRAM(
> + [[
> +#include <stdlib.h>
> +#include <iconv.h>
> + ]],
> + [[iconv_t cd = iconv_open("","");
> iconv(cd,NULL,NULL,NULL,NULL);
> - iconv_close(cd);],
> - INCICONV="-I../libiconv/include"
> - LIBICONV='${top_builddir}'/../libiconv/lib/$_libs/libiconv.a
> - LTLIBICONV='${top_builddir}'/../libiconv/lib/libiconv.la
> - am_cv_lib_iconv=yes
> - am_cv_func_iconv=yes)
> - CPPFLAGS="$am_save_CPPFLAGS"
> - LIBS="$am_save_LIBS"
> - if test "$am_cv_func_iconv" = "yes"; then
> - break
> - fi
> - done
> - fi
> -
> […]
next prev parent reply other threads:[~2023-11-20 16:42 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-26 0:17 [PATCH v2 0/2] Replace intl/ with out-of-tree GNU gettext Arsen Arsenović
2023-09-26 0:17 ` [PATCH v2 1/2] *: add modern gettext support Arsen Arsenović
2023-09-26 2:12 ` Kevin Buettner
2023-09-26 7:03 ` Jan Beulich
2023-09-26 7:54 ` Iain Sandoe
2023-09-26 14:44 ` Arsen Arsenović
2023-09-27 7:11 ` Jan Beulich
2023-09-27 13:06 ` Arsen Arsenović
2023-09-27 15:19 ` Nick Clifton
2023-09-27 17:43 ` Arsen Arsenović
2023-09-28 9:43 ` Nick Clifton
2023-09-29 15:58 ` Bruno Haible
2023-09-29 16:27 ` Arsen Arsenović
2023-11-20 16:42 ` Kévin Le Gouguec [this message]
2023-11-20 20:30 ` Arsen Arsenović
2023-11-20 21:28 ` Bruno Haible
2023-09-26 0:17 ` [PATCH v2 2/2] *: suppress xgettext 0.22 charset name error Arsen Arsenović
2023-09-27 15:21 ` Nick Clifton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874jhg2x6p.fsf@adacore.com \
--to=legouguec@adacore.com \
--cc=arsen@aarsen.me \
--cc=binutils@sourceware.org \
--cc=bruno@clisp.org \
--cc=gdb-patches@sourceware.org \
--cc=iain@sandoe.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).