Re: [PATCH v2 2/2] *: suppress xgettext 0.22 charset name error

[Nick Clifton <nickc@redhat.com>]

Hi Arsen,

> bfd.po: warning: Charset "CHARSET" is not a portable encoding name.
>                   Message conversion to user's charset might not work.
> /usr/bin/xgettext: present charset "CHARSET" is not a portable encoding name
> 
> As Bruno Haible <bruno@clisp.org> suggested:
>>> Perhaps it'd be good to use -o to suppress this warning anyway
>>
>> Yes, regardless of gettext version, you profit of the .pot suffix handling by
>> replacing
>>
>> --default-domain=$(PACKAGE)
>>
>> with
>>
>> -o $(PACKAGE)-tmp.pot
>>
>> (twice) and
>>
>> < $(PACKAGE).po > $@-t
>>
>> with
>>
>> < $(PACKAGE)-tmp.pot > $@-t
> 
> bfd/ChangeLog:
> 
> 	* po/Make-in ($(srcdir)/$(PACKAGE).pot): Output to a .pot
> 	temporary file, to suppress xgettext checking charset names.
> 
> binutils/ChangeLog:
> 
> 	* po/Make-in ($(srcdir)/$(PACKAGE).pot): Output to a .pot
> 	temporary file to suppress xgettext checking charset names.
> 
> gas/ChangeLog:
> 
> 	* po/Make-in ($(srcdir)/$(PACKAGE).pot): Output to a .pot
> 	temporary file to suppress xgettext checking charset names.
> 
> gold/ChangeLog:
> 
> 	* po/Make-in ($(srcdir)/$(PACKAGE).pot): Output to a .pot
> 	temporary file to suppress xgettext checking charset names.
> 
> gprof/ChangeLog:
> 
> 	* po/Make-in ($(srcdir)/$(PACKAGE).pot): Output to a .pot
> 	temporary file to suppress xgettext checking charset names.
> 
> ld/ChangeLog:
> 
> 	* po/Make-in ($(srcdir)/$(PACKAGE).pot): Output to a .pot
> 	temporary file to suppress xgettext checking charset names.
> 
> opcodes/ChangeLog:
> 
> 	* po/Make-in ($(srcdir)/$(PACKAGE).pot): Output to a .pot
> 	temporary file to suppress xgettext checking charset names.

This part of the patch set is approved as well.

Cheers
   Nick