From: Tom de Vries <tdevries@suse.de>
To: gdb-patches@sourceware.org
Subject: [PATCH 00/13] [gdb/symtab, cc-with-dwz] Fix gdb.cp/breakpoint-locs.exp
Date: Mon, 2 Oct 2023 14:50:38 +0200 [thread overview]
Message-ID: <20231002125051.29911-1-tdevries@suse.de> (raw)
[ Submitted an earlier RFC version at
https://sourceware.org/pipermail/gdb-patches/2023-September/202443.html. ]
When running test-case gdb.cp/breakpoint-locs.exp with target board
cc-with-dwz, we occasionally run into:
...
FAIL: gdb.cp/breakpoint-locs.exp: break N1::C1::baz
...
due to the breakpoint having one instead of two locations.
This is PR symtab/30728. This series fixes it.
The fix is dependent on the fix for PR symtab/30846, which is about incorrect
parent entries in the cooked index, due to inter-cu (intra-shard and
inter-shard) references.
The series consists of three parts:
- patches that fix PR symtab/30846.
- patches that add two optimizations to the fix for PR symtab/30846
(one preparation patch, and two optimization patches),
- the last patch, that fixes PR symtab/30728.
The fix for PR symtab/30728 consists of adding entries to the cooked index for
DW_TAG_inlined_subroutine DIEs, with correct parent entries.
Tested on x86_64-linux, with target boards unix, cc-with-dwz and
cc-with-dwz-m.
I've split out the two added test-cases into separate patches. Unfortunately
the patch "[gdb/symtab] Resolve deferred entries, inter-shard case" is still
somewhat large due to moving code about.
Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=30728
Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=30846
Tom de Vries (13):
[gdb/symtab] Factor out m_die_range_map usage
[gdb/symtab] Check effect in parent_map::set_parent
[gdb/symtab] Handle nullptr parent in parent_map::set_parent
[gdb/symtab] Add parent_map::dump
[gdb/symtab] Factor out m_deferred_entries usage
[gdb/symtab] Add debug_handle_deferred_entries
[gdb/symtab] Resolve deferred entries, inter-shard case
[gdb/testsuite] Add gdb.dwarf2/forward-spec-inter-cu.exp
[gdb/symtab] Keep track of processed DIEs in shard
[gdb/symtab] Resolve deferred entries, intra-shard case
[gdb/symtab] Don't defer backward refs, inter-cu intra-shard case
[gdb/testsuite] Add gdb.dwarf2/backward-spec-inter-cu.exp
[gdb/symtab] Add DW_TAG_inlined_subroutine entries in the cooked index
for c++
gdb/addrmap.c | 19 +-
gdb/addrmap.h | 7 +-
gdb/dwarf2/cooked-index.c | 141 ++++++++++++++
gdb/dwarf2/cooked-index.h | 145 +++++++++++++-
gdb/dwarf2/read.c | 178 +++++++++++++-----
.../gdb.dwarf2/backward-spec-inter-cu.exp | 111 +++++++++++
.../gdb.dwarf2/forward-spec-inter-cu.exp | 107 +++++++++++
7 files changed, 657 insertions(+), 51 deletions(-)
create mode 100644 gdb/testsuite/gdb.dwarf2/backward-spec-inter-cu.exp
create mode 100644 gdb/testsuite/gdb.dwarf2/forward-spec-inter-cu.exp
base-commit: 6a6117ab0ffe18ea984abca84869eae799c1b346
--
2.35.3
next reply other threads:[~2023-10-02 12:50 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-02 12:50 Tom de Vries [this message]
2023-10-02 12:50 ` [PATCH 01/13] [gdb/symtab] Factor out m_die_range_map usage Tom de Vries
2023-10-09 20:33 ` Alexandra Petlanova Hajkova
2023-10-09 21:43 ` Tom de Vries
2023-10-20 19:50 ` Tom Tromey
2023-11-30 12:55 ` Tom de Vries
2023-10-02 12:50 ` [PATCH 02/13] [gdb/symtab] Check effect in parent_map::set_parent Tom de Vries
2023-10-20 19:51 ` Tom Tromey
2023-11-30 14:05 ` Tom de Vries
2023-10-02 12:50 ` [PATCH 03/13] [gdb/symtab] Handle nullptr parent " Tom de Vries
2023-10-02 12:50 ` [PATCH 04/13] [gdb/symtab] Add parent_map::dump Tom de Vries
2023-10-10 9:05 ` Alexandra Petlanova Hajkova
2023-10-20 19:51 ` Tom Tromey
2023-10-02 12:50 ` [PATCH 05/13] [gdb/symtab] Factor out m_deferred_entries usage Tom de Vries
2023-10-02 12:50 ` [PATCH 06/13] [gdb/symtab] Add debug_handle_deferred_entries Tom de Vries
2023-10-02 12:50 ` [PATCH 07/13] [gdb/symtab] Resolve deferred entries, inter-shard case Tom de Vries
2023-10-20 20:11 ` Tom Tromey
2023-12-10 8:10 ` Tom de Vries
2023-10-02 12:50 ` [PATCH 08/13] [gdb/testsuite] Add gdb.dwarf2/forward-spec-inter-cu.exp Tom de Vries
2023-10-02 12:50 ` [PATCH 09/13] [gdb/symtab] Keep track of processed DIEs in shard Tom de Vries
2023-10-22 11:00 ` Alexandra Petlanova Hajkova
2023-12-08 12:09 ` Tom de Vries
2023-10-02 12:50 ` [PATCH 10/13] [gdb/symtab] Resolve deferred entries, intra-shard case Tom de Vries
2023-10-02 12:50 ` [PATCH 11/13] [gdb/symtab] Don't defer backward refs, inter-cu " Tom de Vries
2023-10-02 12:50 ` [PATCH 12/13] [gdb/testsuite] Add gdb.dwarf2/backward-spec-inter-cu.exp Tom de Vries
2023-10-02 12:50 ` [PATCH 13/13] [gdb/symtab] Add DW_TAG_inlined_subroutine entries in the cooked index for c++ Tom de Vries
2023-10-16 11:40 ` [PING][PATCH 00/13] [gdb/symtab, cc-with-dwz] Fix gdb.cp/breakpoint-locs.exp Tom de Vries
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231002125051.29911-1-tdevries@suse.de \
--to=tdevries@suse.de \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).