From: Tom Tromey <tromey@adacore.com>
To: gdb-patches@sourceware.org
Subject: [PATCH 0/3] Fix "attach" infinite loop
Date: Tue, 03 Oct 2023 11:56:21 -0600 [thread overview]
Message-ID: <20231003-attach-bug-v1-0-f5de2e583c5d@adacore.com> (raw)
A user noticed that if you strace the non-main thread of a program,
then if you try to attach gdb to that program, gdb will enter an
infinite loop.
This series fixes this bug, but has a couple extra small cleanup
patches as well.
Regression tested on x86-64 Fedora 36.
---
Tom Tromey (3):
Minor cleanup in linux_proc_attach_tgid_threads
Use gdb_dir_up in linux_proc_attach_tgid_threads
Bail out of "attach" if a thread cannot be traced
gdb/linux-nat.c | 49 +++++++++++----
gdb/nat/linux-procfs.c | 11 ++--
gdb/testsuite/gdb.base/traced-thread.c | 105 +++++++++++++++++++++++++++++++
gdb/testsuite/gdb.base/traced-thread.exp | 54 ++++++++++++++++
gdbserver/linux-low.cc | 15 ++++-
5 files changed, 214 insertions(+), 20 deletions(-)
---
base-commit: 1c9b44fe07569b6ed99557faa87d5b1c21413fbf
change-id: 20231003-attach-bug-ec9c00e86086
Best regards,
--
Tom Tromey <tromey@adacore.com>
next reply other threads:[~2023-10-03 17:56 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-03 17:56 Tom Tromey [this message]
2023-10-03 17:56 ` [PATCH 1/3] Minor cleanup in linux_proc_attach_tgid_threads Tom Tromey
2023-10-04 1:29 ` Simon Marchi
2023-10-03 17:56 ` [PATCH 2/3] Use gdb_dir_up " Tom Tromey
2023-10-04 1:30 ` Simon Marchi
2023-10-03 17:56 ` [PATCH 3/3] Bail out of "attach" if a thread cannot be traced Tom Tromey
2023-10-04 1:29 ` Simon Marchi
2023-10-04 14:14 ` Tom Tromey
2023-10-04 17:38 ` Simon Marchi
2023-12-01 17:41 ` [PATCH 0/3] Fix "attach" infinite loop Tom Tromey
2023-12-04 14:25 ` Luis Machado
2023-12-05 19:27 ` Tom Tromey
2023-12-15 19:33 ` Tom Tromey
2023-12-18 9:50 ` Luis Machado
2023-12-18 11:33 ` Luis Machado
2023-12-18 14:30 ` Tom Tromey
2023-12-18 15:10 ` Luis Machado
2024-01-02 19:14 ` Carl Love
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231003-attach-bug-v1-0-f5de2e583c5d@adacore.com \
--to=tromey@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).