From: Tom Tromey <tromey@adacore.com>
To: gdb-patches@sourceware.org
Subject: [PATCH 1/3] Minor cleanup in linux_proc_attach_tgid_threads
Date: Tue, 03 Oct 2023 11:56:22 -0600 [thread overview]
Message-ID: <20231003-attach-bug-v1-1-f5de2e583c5d@adacore.com> (raw)
In-Reply-To: <20231003-attach-bug-v1-0-f5de2e583c5d@adacore.com>
linux_proc_attach_tgid_threads computes a file name, and then
re-computes it for a warning. It is better to reuse the
already-computed name here.
---
gdb/nat/linux-procfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/gdb/nat/linux-procfs.c b/gdb/nat/linux-procfs.c
index 9c2d1beb91f..95ecae443e4 100644
--- a/gdb/nat/linux-procfs.c
+++ b/gdb/nat/linux-procfs.c
@@ -287,7 +287,7 @@ linux_proc_attach_tgid_threads (pid_t pid,
dir = opendir (pathname);
if (dir == NULL)
{
- warning (_("Could not open /proc/%ld/task."), (long) pid);
+ warning (_("Could not open %s."), pathname);
return;
}
--
2.40.1
next prev parent reply other threads:[~2023-10-03 17:56 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-03 17:56 [PATCH 0/3] Fix "attach" infinite loop Tom Tromey
2023-10-03 17:56 ` Tom Tromey [this message]
2023-10-04 1:29 ` [PATCH 1/3] Minor cleanup in linux_proc_attach_tgid_threads Simon Marchi
2023-10-03 17:56 ` [PATCH 2/3] Use gdb_dir_up " Tom Tromey
2023-10-04 1:30 ` Simon Marchi
2023-10-03 17:56 ` [PATCH 3/3] Bail out of "attach" if a thread cannot be traced Tom Tromey
2023-10-04 1:29 ` Simon Marchi
2023-10-04 14:14 ` Tom Tromey
2023-10-04 17:38 ` Simon Marchi
2023-12-01 17:41 ` [PATCH 0/3] Fix "attach" infinite loop Tom Tromey
2023-12-04 14:25 ` Luis Machado
2023-12-05 19:27 ` Tom Tromey
2023-12-15 19:33 ` Tom Tromey
2023-12-18 9:50 ` Luis Machado
2023-12-18 11:33 ` Luis Machado
2023-12-18 14:30 ` Tom Tromey
2023-12-18 15:10 ` Luis Machado
2024-01-02 19:14 ` Carl Love
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231003-attach-bug-v1-1-f5de2e583c5d@adacore.com \
--to=tromey@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).