public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Simon Marchi <simark@simark.ca>
To: Tom Tromey <tromey@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 3/3] Bail out of "attach" if a thread cannot be traced
Date: Wed, 4 Oct 2023 13:38:29 -0400	[thread overview]
Message-ID: <d992f873-8bd0-4bf0-9cc4-28d8daa53f42@simark.ca> (raw)
In-Reply-To: <87ttr6xyo6.fsf@tromey.com>

On 10/4/23 10:14, Tom Tromey wrote:
> Simon> I don't rely on that behavior myself, but I would think that the current
> Simon> behavior of just warning when failing to attach to a thread was on
> Simon> purpose, at least it allows the user to debug the other threads.  It
> Simon> might be useful in some edge case scenarios I guess?
> 
> Yes, I don't really know.  However, it seemed to me to be less bad to
> simply fail entirely.  We could make gdb just ignore these
> already-traced threads -- but then debugging might be quite strange,
> because the untraced thread would never stop.

Yeah, and it will be weird if an untraced thread hits a breakpoint.
Whatever traces it will get notified that the thread received a SIGTRAP.
I would ask Pedro for his opinion, just to be sure.

Simon

  reply	other threads:[~2023-10-04 17:38 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-03 17:56 [PATCH 0/3] Fix "attach" infinite loop Tom Tromey
2023-10-03 17:56 ` [PATCH 1/3] Minor cleanup in linux_proc_attach_tgid_threads Tom Tromey
2023-10-04  1:29   ` Simon Marchi
2023-10-03 17:56 ` [PATCH 2/3] Use gdb_dir_up " Tom Tromey
2023-10-04  1:30   ` Simon Marchi
2023-10-03 17:56 ` [PATCH 3/3] Bail out of "attach" if a thread cannot be traced Tom Tromey
2023-10-04  1:29   ` Simon Marchi
2023-10-04 14:14     ` Tom Tromey
2023-10-04 17:38       ` Simon Marchi [this message]
2023-12-01 17:41 ` [PATCH 0/3] Fix "attach" infinite loop Tom Tromey
2023-12-04 14:25   ` Luis Machado
2023-12-05 19:27     ` Tom Tromey
2023-12-15 19:33       ` Tom Tromey
2023-12-18  9:50         ` Luis Machado
2023-12-18 11:33           ` Luis Machado
2023-12-18 14:30             ` Tom Tromey
2023-12-18 15:10               ` Luis Machado
2024-01-02 19:14                 ` Carl Love

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d992f873-8bd0-4bf0-9cc4-28d8daa53f42@simark.ca \
    --to=simark@simark.ca \
    --cc=gdb-patches@sourceware.org \
    --cc=tromey@adacore.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).