public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Guinevere Larsen <blarsen@redhat.com>
To: gdb-patches@sourceware.org
Cc: eliz@gnu.org, Guinevere Larsen <blarsen@redhat.com>
Subject: [PATCH v5 0/1] update MAINTAINERS file with git trailers
Date: Thu,  5 Oct 2023 13:35:33 +0200	[thread overview]
Message-ID: <20231005113533.86112-2-blarsen@redhat.com> (raw)

Some private chats highlighted that the currently in use git trailers
aren't explained well enough. This patch aims to fix that by adding the
information in a more verbose way to guarantee that everyone is on the
same page about them and refine anything that might still need work.

I forgot that Kevin had given a soft approval of this, so I kept his
review tag, but further chatter on the latest cauldron conference had
people agreeing that Acked-by should be used as partial approval, so I
reworded that section of the patch to be more inline with how other
projects use it.

One concern that was raised in the conference is how b4 reacts to
trailing parenthesis. It seems that newer b4 versions (at least on
0.12.3) drop that, while older versions (0.10.1) keep it. I'm not sure
if this change was intentional or not, and I have informed the b4
project of the regression, but this raises the question: Do we want to
have the trailing parenthesis saying which areas were approved by an
ack, or is it ok to just have it in regular text?

Personally I like adding it either way in replies, but not making it a
requirement when pushing code, so its easy to see in old emails and no
one gets inconvenienced, but I'm not dead set on this.

Guinevere Larsen (1):
  [gdb]: add git trailer information on gdb/MAINTAINERS

 gdb/MAINTAINERS | 72 +++++++++++++++++++++++++++++++++++++++++++------
 1 file changed, 64 insertions(+), 8 deletions(-)

-- 
2.41.0


             reply	other threads:[~2023-10-05 11:45 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-05 11:35 Guinevere Larsen [this message]
2023-10-05 11:35 ` [PATCH v5 1/1] [gdb]: add git trailer information on gdb/MAINTAINERS Guinevere Larsen
2023-10-05 14:31   ` Simon Marchi
2023-10-05 16:01   ` Eli Zaretskii
2023-10-06  7:39     ` Guinevere Larsen
2023-10-06 11:11       ` Eli Zaretskii
2023-10-05 17:55   ` Kevin Buettner
2023-10-09  9:59     ` Guinevere Larsen
2023-10-10 15:14       ` Simon Marchi
2023-10-26 12:46         ` Lancelot SIX
2023-10-25 14:34 ` [PING][PATCH v5 0/1] update MAINTAINERS file with git trailers Guinevere Larsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231005113533.86112-2-blarsen@redhat.com \
    --to=blarsen@redhat.com \
    --cc=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).