Re: [PATCH v5 1/1] [gdb]: add git trailer information on gdb/MAINTAINERS

[Eli Zaretskii <eliz@gnu.org>]

> Date: Fri, 6 Oct 2023 09:39:01 +0200
> Cc: gdb-patches@sourceware.org, kevinb@redhat.com
> From: Guinevere Larsen <blarsen@redhat.com>
> 
> On 05/10/2023 18:01, Eli Zaretskii wrote:
> >> +   This tag is also often described as "partial approval"
> >> +   Usage: "Acked-By: Your Name <your@email> (area)"
> > What are the possible "area"s?  And how to indicate more than a single
> > area?
> "area of GDB" is used throughout the maintainers file without being 
> specified anywhere, such as when explaining "Authorized Comitters":
>    - The Authorized Committers.
> 
>      These are developers who are trusted to make changes within a specific
>      area of GDB without additional oversight.
> 
> And all throughout the "Responsible maintainers" section. So I think it 
> is understood well enough, especially since it is expected that the 
> reviewers are the ones who should know if the patch touches multiple 
> areas and so on.

Fine by me, but then I think the text describing the tags should say
explicitly that the areas are those mentioned elsewhere in the
document.

> > And a more general question: when the review comments are minor, we
> > are used to say something like "okay with those nits fixed", meaning
> > that there's no need for posting another version of the patch before
> > committing it "with those nits fixed".  Is this an
> > Acked-By/Approved-By or Reviewed-By?
> 
> The tags are just ways to make your intent obvious. If you were 
> approving the patch "with the nits fixed", you use Approved-By, if you 
> were approving only parts of the patch, use Acked-by, and if you think 
> the patch is ok but can't/won't approve, use Reviewed-By.

I think this should also be in the document explicitly.

Thanks.