Re: [PATCH v5 1/1] [gdb]: add git trailer information on gdb/MAINTAINERS

[Simon Marchi <simark@simark.ca>]

On 10/9/23 05:59, Guinevere Larsen wrote:
> I understand what you mean, and I see where I may have misunderstood when I said that "Acked-By" worked as partial review in QEMU.
> 
> I'm fine with this being the default if everyone agrees with it. To summarize informally, the tags would be like this:
> 
> * Acked-By: A maintainer of a certain area looked at the patch description and is fine with its direction. this says nothing about the quality of the code. May be restricted to some areas of the code
> * Reviewed-By: A contributor has looked at the code and thinks it is good, but is not approving it for any reason. May be restricted to some areas of the code.
> * Approved-By: A maintainer has looked at the code and thinks that it is ready for upstreaming. May be restricted to some areas, and may be conditional on receiving a review or ack for some area(s).

I like this use of Acked-By, it matches the meaning I thought it had,
based on what other projects do.  It happens that we say something like
"I gave it a quick look and it looks fine to me", indicating that we did
not do a thorough review, in which case Acked-By is appropriate.

Simon