public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Tom Tromey <tromey@adacore.com>
To: gdb-patches@sourceware.org
Subject: [PATCH 0/4] Improve Ada name lookup performance
Date: Tue, 21 Nov 2023 14:09:24 -0700	[thread overview]
Message-ID: <20231121-ada-lookup-perf-v1-0-1efd2d1dbf65@adacore.com> (raw)

This series started when a user noticed that gdb was very slow to
print Ada records in a large program.  I tracked this down and fixed
it in patch #1.  However, then I noticed that, with a little work, an
entire method could be removed from quick_symbol_functions.  This is
desirable because this method was only used by Ada.

I regression tested this on x86-64 Fedora 38.  I also used regression
tested using the .debug_names and .gdb_index target boards.  It's also
been run through the AdaCore internal test suite.

---
Tom Tromey (4):
      Improve performance of Ada name searches
      Always use expand_symtabs_matching in ada-lang.c
      Remove split_style::UNDERSCORE
      Remove quick_symbol_functions::expand_matching_symbols

 gdb/ada-lang.c                | 111 ++++--------------------
 gdb/ada-lang.h                |  14 +++-
 gdb/dwarf2/cooked-index.c     |   6 +-
 gdb/dwarf2/read-debug-names.c |  46 ----------
 gdb/dwarf2/read-gdb-index.c   | 190 ------------------------------------------
 gdb/dwarf2/read.c             |  54 ------------
 gdb/objfiles.h                |   6 --
 gdb/psymtab.c                 | 104 -----------------------
 gdb/psymtab.h                 |   7 --
 gdb/quick-symbol.h            |  27 ------
 gdb/split-name.c              |  13 ---
 gdb/split-name.h              |   2 -
 gdb/symfile-debug.c           |  18 ----
 gdb/symtab.h                  |  13 ++-
 14 files changed, 40 insertions(+), 571 deletions(-)
---
base-commit: 97b29a61f7f001550fe985bf2deea1550e3c20dd
change-id: 20231121-ada-lookup-perf-67f46d937484

Best regards,
-- 
Tom Tromey <tromey@adacore.com>


             reply	other threads:[~2023-11-21 21:09 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-21 21:09 Tom Tromey [this message]
2023-11-21 21:09 ` [PATCH 1/4] Improve performance of Ada name searches Tom Tromey
2023-11-21 21:09 ` [PATCH 2/4] Always use expand_symtabs_matching in ada-lang.c Tom Tromey
2023-11-21 21:09 ` [PATCH 3/4] Remove split_style::UNDERSCORE Tom Tromey
2023-11-21 21:09 ` [PATCH 4/4] Remove quick_symbol_functions::expand_matching_symbols Tom Tromey
2023-12-06 17:01 ` [PATCH 0/4] Improve Ada name lookup performance Tom Tromey
2023-12-06 17:04   ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231121-ada-lookup-perf-v1-0-1efd2d1dbf65@adacore.com \
    --to=tromey@adacore.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).