From: Tom Tromey <tromey@adacore.com>
To: Tom Tromey <tromey@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 0/4] Improve Ada name lookup performance
Date: Wed, 06 Dec 2023 10:04:57 -0700 [thread overview]
Message-ID: <87y1e7i7nq.fsf@tromey.com> (raw)
In-Reply-To: <8734wfjmdl.fsf@tromey.com> (Tom Tromey's message of "Wed, 06 Dec 2023 10:01:42 -0700")
Tom> This series started when a user noticed that gdb was very slow to
Tom> print Ada records in a large program. I tracked this down and fixed
Tom> it in patch #1. However, then I noticed that, with a little work, an
Tom> entire method could be removed from quick_symbol_functions. This is
Tom> desirable because this method was only used by Ada.
Tom> I regression tested this on x86-64 Fedora 38. I also used regression
Tom> tested using the .debug_names and .gdb_index target boards. It's also
Tom> been run through the AdaCore internal test suite.
> I rebased this today and I think it needs a little work. It regressed
> gdb.dap/pause.exp, and then when looking at that I wondered what would
> happen if an inferior call caused an unexpected stop... so I think it
> may need another new test as well.
I meant to send this reply to the DAP "stop reason" series.
I was going to send a different reply to the Ada name lookup series --
I'm checking it in.
Tom
prev parent reply other threads:[~2023-12-06 17:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-21 21:09 Tom Tromey
2023-11-21 21:09 ` [PATCH 1/4] Improve performance of Ada name searches Tom Tromey
2023-11-21 21:09 ` [PATCH 2/4] Always use expand_symtabs_matching in ada-lang.c Tom Tromey
2023-11-21 21:09 ` [PATCH 3/4] Remove split_style::UNDERSCORE Tom Tromey
2023-11-21 21:09 ` [PATCH 4/4] Remove quick_symbol_functions::expand_matching_symbols Tom Tromey
2023-12-06 17:01 ` [PATCH 0/4] Improve Ada name lookup performance Tom Tromey
2023-12-06 17:04 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y1e7i7nq.fsf@tromey.com \
--to=tromey@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).