From: Mike Frysinger <vapier@gentoo.org>
To: gdb-patches@sourceware.org
Subject: [PATCH/committed] sim: ppc: phb: add missing break to address decoder
Date: Thu, 21 Dec 2023 01:21:42 -0500 [thread overview]
Message-ID: <20231221062142.3958-1-vapier@gentoo.org> (raw)
I don't know what this emulation does exactly, but it missing a break
statement seems kind of obvious based on the 32-bit case above it.
---
sim/ppc/hw_phb.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/sim/ppc/hw_phb.c b/sim/ppc/hw_phb.c
index ec1119ee7d9b..06eb29fc5a77 100644
--- a/sim/ppc/hw_phb.c
+++ b/sim/ppc/hw_phb.c
@@ -652,6 +652,7 @@ hw_phb_unit_decode(device *me,
&& val != 0x10 && val != 0x18 && val != 0x20)
device_error(me, "Register number (0x%lx) invalid in 64bit PCI address %s",
val, unit);
+ break;
case ss_config_code:
device_error(me, "internal error");
}
--
2.43.0
reply other threads:[~2023-12-21 6:21 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231221062142.3958-1-vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).